🛡️ Sentinel: Hardened SSH security in build workflow#232
🛡️ Sentinel: Hardened SSH security in build workflow#232christopherfoxjr wants to merge 2 commits into
Conversation
- Replaced insecure `sshpass -p` with `sshpass -e` to avoid credential exposure in process lists. - Implemented host key verification using `ssh-keyscan` instead of disabling it with `StrictHostKeyChecking=no`. - Updated `.Jules/sentinel.md` with security learning. Co-authored-by: christopherfoxjr <213370400+christopherfoxjr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,4 @@ | |||
| ## 2025-05-15 - Insecure SSH credentials in build workflow | |||
| **Vulnerability:** The `kiba.yml` workflow was using `sshpass -p "$SF_PASS"` and `StrictHostKeyChecking=no`. | |||
2 participants
🚨 Severity: HIGH
💡 Vulnerability: Insecure SSH credential handling and host key verification in
kiba.yml.🎯 Impact: Credentials could be exposed in system process lists, and disabling host key verification invited Man-In-The-Middle (MITM) attacks.
🔧 Fix: Used
sshpass -ewith theSSHPASSenvironment variable and implemented proper host key scanning withssh-keyscan.✅ Verification: Confirmed file changes in
.github/workflows/kiba.ymland verified workflow syntax withcheck_workflows.py.PR created automatically by Jules for task 976250922199913536 started by @christopherfoxjr