🛡️ Sentinel: Fix insecure SSH upload practices in CI#235
Conversation
- Switch from `sshpass -p` to `sshpass -e` for safer secret handling. - Implement host key verification with `ssh-keyscan`. - Remove insecure `StrictHostKeyChecking=no` flag from rsync. Co-authored-by: christopherfoxjr <213370400+christopherfoxjr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 participant
This PR improves the security of the KibaOS Build workflow by hardening the SSH connection used for uploading ISOs to SourceForge.
🚨 Severity: HIGH
💡 Vulnerability: Insecure SSH practices
The previous implementation used
sshpass -pwhich can expose secrets in process listings, andStrictHostKeyChecking=nowhich disabled host identity verification, making the workflow vulnerable to Man-in-the-Middle (MITM) attacks.🎯 Impact:
A malicious actor could potentially intercept the SSH connection and redirect the upload to a rogue server or perform a MITM attack.
🔧 Fix:
sshpass -p "$SF_PASS"withsshpass -eand mapped${{ secrets.SF_PASS }}to theSSHPASSenvironment variable.ssh-keyscanstep to verify the SourceForge host key before connecting.-o StrictHostKeyChecking=noflag from thersynccommand.✅ Verification:
PR created automatically by Jules for task 1561495136014994700 started by @christopherfoxjr