Skip to content

Initial implementation of DetectedMCPClients[]#179

Merged
rhennigan merged 4 commits into
mainfrom
feature/DetectedMCPClients
May 7, 2026
Merged

Initial implementation of DetectedMCPClients[]#179
rhennigan merged 4 commits into
mainfrom
feature/DetectedMCPClients

Conversation

@rhennigan
Copy link
Copy Markdown
Member

No description provided.

This will be needed by both the Welcome Screen (which we knew already) and the Preferences dialog (which we didn't). So I think it makes sense for this utility to live in this paclet.

It returns all $SupportedMCPClients for which the "InstallLocation" file actually exists. We may want to put more effort into this, but it will be useful even in this simple form.
Copilot AI review requested due to automatic review settings May 7, 2026 13:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new public API DetectedMCPClients[] to the AgentTools paclet to identify which supported MCP clients appear to be installed/configured based on known config-file locations.

Changes:

  • Export DetectedMCPClients as a public symbol (PacletInfo + protected names list).
  • Implement DetectedMCPClients[] in Kernel/PreferencesContent.wl by filtering $SupportedMCPClients based on whether the inferred install-location file exists.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
PacletInfo.wl Adds Wolfram\AgentTools`DetectedMCPClients` to exported symbols.
Kernel/PreferencesContent.wl Implements DetectedMCPClients[] by selecting supported clients with existing install-location files.
Kernel/Main.wl Exports and protects the new DetectedMCPClients symbol.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Kernel/PreferencesContent.wl Outdated
Comment thread Kernel/PreferencesContent.wl Outdated
Comment thread Kernel/PreferencesContent.wl Outdated
Comment thread Kernel/PreferencesContent.wl Outdated
Comment thread Kernel/PreferencesContent.wl Outdated
Replace inline path resolution with the canonical installLocation helper
(wrapped in catchAlways so OS-specific lookup failures don't propagate)
and return Keys to match the function's plural name. Adds initial tests.
Comment thread Kernel/SupportedClients.wl Outdated
@rhennigan rhennigan requested a review from Copilot May 7, 2026 14:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread Tests/SupportedClients.wlt Outdated
Comment thread Tests/SupportedClients.wlt Outdated
Comment thread Kernel/SupportedClients.wl
rhennigan and others added 2 commits May 7, 2026 14:45
DetectedMCPClients[] now returns the metadata association of detected
clients instead of just their names, since consumers need the data.
Updates the ordering test to assert preservation of $SupportedMCPClients
order rather than Sort order.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 7, 2026 14:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@rhennigan rhennigan merged commit fb4b52b into main May 7, 2026
5 checks passed
@rhennigan rhennigan deleted the feature/DetectedMCPClients branch May 7, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants