Skip to content

Commit 1174ef6

Browse files
committed
Fix phpstan issues
1 parent 92f2b62 commit 1174ef6

6 files changed

Lines changed: 7 additions & 12 deletions

File tree

wcfsetup/install/files/lib/acp/page/LanguageItemListPage.class.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,13 @@
44

55
use wcf\page\AbstractGridViewPage;
66
use wcf\system\gridView\admin\LanguageItemGridView;
7-
use wcf\system\WCF;
87

98
/**
109
* Shows a list of language items.
1110
*
1211
* @author Olaf Braun, Marcel Werk
1312
* @copyright 2001-2025 WoltLab GmbH
14-
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
13+
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
1514
*
1615
* @extends AbstractGridViewPage<LanguageItemGridView>
1716
*/
@@ -30,6 +29,6 @@ final class LanguageItemListPage extends AbstractGridViewPage
3029
#[\Override]
3130
protected function createGridView(): LanguageItemGridView
3231
{
33-
return new LanguageItemGridView(WCF::getLanguage());
32+
return new LanguageItemGridView();
3433
}
3534
}

wcfsetup/install/files/lib/system/attachment/IAttachmentObjectType.class.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@
33
namespace wcf\system\attachment;
44

55
use wcf\data\attachment\Attachment;
6-
use wcf\data\IUserContent;
76

87
/**
98
* Any attachment object type should implement this interface.
109
*
1110
* @author Marcel Werk
1211
* @copyright 2001-2019 WoltLab GmbH
1312
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
14-
* @template T of IUserContent
13+
* @template T of object
1514
*/
1615
interface IAttachmentObjectType
1716
{

wcfsetup/install/files/lib/system/endpoint/controller/core/gridViews/GetRows.class.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
6363
/**
6464
* @param list<string> $ids
6565
* @return array<string, string>
66+
* @phpstan-ignore missingType.generics
6667
*/
6768
private function getFilterLabels(AbstractGridView $view, array $ids): array
6869
{

wcfsetup/install/files/lib/system/endpoint/controller/core/listViews/GetItems.class.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
6363
/**
6464
* @param list<string> $ids
6565
* @return array<string, string>
66+
* @phpstan-ignore missingType.generics
6667
*/
6768
private function getFilterLabels(AbstractListView $view, array $ids): array
6869
{

wcfsetup/install/files/lib/system/gridView/GridViewColumn.class.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace wcf\system\gridView;
44

55
use wcf\data\DatabaseObject;
6-
use wcf\system\exception\ParentClassException;
76
use wcf\system\form\builder\field\AbstractFormField;
87
use wcf\system\view\filter\IViewFilter;
98
use wcf\system\gridView\renderer\DefaultColumnRenderer;
@@ -176,10 +175,6 @@ public function getSortByDatabaseColumn(): string
176175
public function filter(IViewFilter|string|null $filter): static
177176
{
178177
if (\is_string($filter)) {
179-
if (!\is_subclass_of($filter, IViewFilter::class)) {
180-
throw new ParentClassException($filter, IViewFilter::class);
181-
}
182-
183178
$possibleValues = [
184179
'id' => $this->getID(),
185180
'languageItem' => $this->getLabel(),
@@ -223,7 +218,7 @@ public function getFilterFormField(): AbstractFormField
223218
throw new \LogicException('This column has no filter.');
224219
}
225220

226-
return $this->getFilter()->getFormField($this->getID(), $this->getLabel());
221+
return $this->getFilter()->getFormField();
227222
}
228223

229224
/**

wcfsetup/install/files/lib/system/gridView/admin/LanguageItemGridView.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
*/
3737
final class LanguageItemGridView extends AbstractGridView
3838
{
39-
public function __construct(?Language $defaultLanguage = null)
39+
public function __construct()
4040
{
4141
$availableLanguages = $this->getAvailableLanguages();
4242

0 commit comments

Comments
 (0)