Skip to content

Commit 2721ddc

Browse files
authored
Merge pull request #6351 from WoltLab/6.2-article-templates-unsafe
Refactor article templates
2 parents e3c0646 + d73299f commit 2721ddc

9 files changed

Lines changed: 159 additions & 144 deletions

File tree

com.woltlab.wcf/templates/articleAdd.tpl

Lines changed: 75 additions & 68 deletions
Large diffs are not rendered by default.

com.woltlab.wcf/templates/boxArticleList.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,4 @@
6969
</li>
7070
{/foreach}
7171
</ul>
72-
{if}
72+
{/if}

com.woltlab.wcf/templates/categoryArticleList.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
{capture assign='contentHeaderNavigation'}
2222
{if $canManageArticles}
2323
{if $availableLanguages|count > 1}
24-
<li><button type="button" class="button buttonPrimary jsButtonArticleAdd">{icon name='plus'} <span>{lang}wcf.acp.article.add{/lang}</span></a></li>
24+
<li><button type="button" class="button buttonPrimary jsButtonArticleAdd">{icon name='plus'} <span>{lang}wcf.acp.article.add{/lang}</span></button></li>
2525
{else}
2626
<li><a href="{link controller='ArticleAdd'}categoryID={$category->categoryID}{/link}" class="button buttonPrimary">{icon name='plus'} <span>{lang}wcf.acp.article.add{/lang}</span></a></li>
2727
{/if}

com.woltlab.wcf/templates/moderationArticle.tpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66

77
<div class="messageHeaderBox">
88
<h2 class="messageTitle">
9-
<a href="{@$article->getLink()}">{$article->getTitle()}</a>
9+
<a href="{$article->getLink()}">{$article->getTitle()}</a>
1010
</h2>
1111

1212
<ul class="messageHeaderMetaData">
1313
<li>{user object=$article->getUserProfile() class='username'}</li>
14-
<li><span class="messagePublicationTime">{@$article->time|time}</span></li>
14+
<li><span class="messagePublicationTime">{time time=$article->time}</span></li>
1515

1616
{event name='messageHeaderMetaData'}
1717
</ul>
@@ -25,7 +25,7 @@
2525
{event name='beforeMessageText'}
2626

2727
<div class="messageText">
28-
{@$article->getFormattedContent()}
28+
{unsafe:$article->getFormattedContent()}
2929
</div>
3030

3131
{event name='afterMessageText'}

com.woltlab.wcf/templates/searchArticle.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<select name="articleCategoryID" id="articleCategoryID">
55
<option value="">{lang}wcf.global.noSelection{/lang}</option>
66
{foreach from=$articleCategoryList item=category}
7-
<option value="{$category->categoryID}">{if $category->getDepth() > 1}{@'&nbsp;&nbsp;&nbsp;&nbsp;'|str_repeat:-1+$category->getDepth()}{/if}{$category->getTitle()}</option>
7+
<option value="{$category->categoryID}">{if $category->getDepth() > 1}{unsafe:'&nbsp;&nbsp;&nbsp;&nbsp;'|str_repeat:-1+$category->getDepth()}{/if}{$category->getTitle()}</option>
88
{/foreach}
99
</select>
1010
</dd>

com.woltlab.wcf/templates/shared_articleAddDialog.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
'wcf.acp.article.add': '{jslang}wcf.acp.article.add{/jslang}'
2222
});
2323
24-
AcpUiArticleAdd.init('{link controller='ArticleAdd' encode=false}{literal}isMultilingual={$isMultilingual}{/literal}{if $categoryID}&categoryID={@$categoryID}{/if}{/link}');
24+
AcpUiArticleAdd.init('{link controller='ArticleAdd' encode=false}{literal}isMultilingual={$isMultilingual}{/literal}{if $categoryID}&categoryID={$categoryID}{/if}{/link}');
2525
2626
{if $showArticleAddDialog}
2727
window.setTimeout(function() {

wcfsetup/install/files/acp/templates/articleAdd.tpl

Lines changed: 75 additions & 68 deletions
Large diffs are not rendered by default.

wcfsetup/install/files/acp/templates/articleCategoryDialog.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<option value="0">{lang}wcf.global.noSelection{/lang}</option>
77

88
{foreach from=$categoryNodeList item=category}
9-
<option value="{$category->categoryID}">{if $category->getDepth() > 1}{@"&nbsp;&nbsp;&nbsp;&nbsp;"|str_repeat:($category->getDepth() - 1)}{/if}{$category->getTitle()}</option>
9+
<option value="{$category->categoryID}">{if $category->getDepth() > 1}{unsafe:"&nbsp;&nbsp;&nbsp;&nbsp;"|str_repeat:($category->getDepth() - 1)}{/if}{$category->getTitle()}</option>
1010
{/foreach}
1111
</select>
1212
</dd>

wcfsetup/install/files/lib/system/box/ArticleListBoxController.class.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ protected function getTemplate()
9494
return WCF::getTPL()->render('wcf', 'boxArticleList', [
9595
'boxArticleList' => $this->objectList,
9696
'boxSortField' => $this->sortField,
97+
'boxPosition' => $this->box->position,
9798
]);
9899
}
99100
}

0 commit comments

Comments
 (0)