Merge pull request #6640 from WoltLab/63-method-parameter-typings2

Add missing typings to interface methods

Author: BurntimeX

com.woltlab.wcf/templates/commentList.tpl

@@ -37,7 +37,7 @@
 							<span class="badge label green comment__status--disabled">{lang}wcf.message.status.disabled{/lang}</span>
 						{/if}
 
-						{if $commentManager->isContentAuthor($comment)}
+						{if $commentManager->isContentAuthor($comment->getDecoratedObject())}
 							<span class="badge label">{lang}wcf.comment.objectAuthor{/lang}</span>
 						{/if}
 

com.woltlab.wcf/templates/commentResponseList.tpl

@@ -33,7 +33,7 @@
 							<span class="badge label green commentResponse__status--disabled">{lang}wcf.message.status.disabled{/lang}</span>
 						{/if}
 
-						{if $commentManager->isContentAuthor($response)}
+						{if $commentManager->isContentAuthor($response->getDecoratedObject())}
 							<span class="badge label">{lang}wcf.comment.objectAuthor{/lang}</span>
 						{/if}
 

wcfsetup/install/files/lib/data/DatabaseObject.class.php

@@ -96,7 +96,7 @@ protected function handleData($data)
     /**
      * @inheritDoc
      */
-    public function __get($name)
+    public function __get(string $name)
     {
         return $this->data[$name] ?? null;
     }
@@ -114,7 +114,7 @@ public function getObjectID()
     /**
      * @inheritDoc
      */
-    public function __isset($name)
+    public function __isset(string $name)
     {
         return isset($this->data[$name]);
     }

wcfsetup/install/files/lib/data/DatabaseObjectDecorator.class.php

@@ -47,15 +47,15 @@ public function __construct(DatabaseObject $object)
     /**
      * @inheritDoc
      */
-    public function __get($name)
+    public function __get(string $name)
     {
         return $this->object->__get($name);
     }
 
     /**
      * @inheritDoc
      */
-    public function __isset($name)
+    public function __isset(string $name)
     {
         return $this->object->__isset($name);
     }

wcfsetup/install/files/lib/data/DatabaseObjectList.class.php

@@ -403,7 +403,7 @@ public function seek($offset): void
     /**
      * @inheritDoc
      */
-    public function seekTo($objectID)
+    public function seekTo(int $objectID)
     {
         $this->index = \array_search($objectID, $this->indexToObject);
 
@@ -415,7 +415,7 @@ public function seekTo($objectID)
     /**
      * @inheritDoc
      */
-    public function search($objectID)
+    public function search(int $objectID)
     {
         try {
             $this->seekTo($objectID);

wcfsetup/install/files/lib/data/IDatabaseObjectProcessor.class.php

@@ -16,26 +16,23 @@ public function __construct(DatabaseObject $object);
     /**
      * Delegates accesses to inaccessible object properties the processed object.
      *
-     * @param string $name
      * @return mixed
      */
-    public function __get($name);
+    public function __get(string $name);
 
     /**
      * Delegates isset calls for inaccessible object properties to the processed
      * object.
      *
-     * @param string $name
      * @return bool
      */
-    public function __isset($name);
+    public function __isset(string $name);
 
     /**
      * Delegates inaccessible method calls to the processed database object.
      *
-     * @param string $name
      * @param mixed[] $arguments
      * @return mixed
      */
-    public function __call($name, $arguments);
+    public function __call(string $name, array $arguments);
 }

wcfsetup/install/files/lib/data/IMessage.class.php

@@ -14,10 +14,9 @@ interface IMessage extends IUserContent
     /**
      * Returns a simplified message (only inline codes), truncated to 255 characters by default.
      *
-     * @param int $maxLength
      * @return  string
      */
-    public function getExcerpt($maxLength = 255);
+    public function getExcerpt(int $maxLength = 255);
 
     /**
      * Returns formatted message text.

wcfsetup/install/files/lib/data/IPermissionObject.class.php

@@ -26,8 +26,7 @@ public function checkPermissions(array $permissions);
      * Returns the permission value of the given permission for this object
      * and the active user.
      *
-     * @param string $permission
      * @return mixed
      */
-    public function getPermission($permission);
+    public function getPermission(string $permission);
 }

wcfsetup/install/files/lib/data/IStorableObject.class.php

@@ -15,19 +15,17 @@ interface IStorableObject
      * Returns the value of a object data variable with the given name or `null` if no
      * such data variable exists.
      *
-     * @param string $name
      * @return mixed
      */
-    public function __get($name);
+    public function __get(string $name);
 
     /**
      * Determines if the object data variable with the given name is set and
      * is not NULL.
      *
-     * @param string $name
      * @return bool
      */
-    public function __isset($name);
+    public function __isset(string $name);
 
     /**
      * Returns the value of all object data variables.

wcfsetup/install/files/lib/data/IThumbnailFile.class.php

@@ -16,18 +16,16 @@ interface IThumbnailFile extends IFile
     /**
      * Returns the link to the thumbnail file with the given size.
      *
-     * @param string $size
      * @return string
      */
-    public function getThumbnailLink($size);
+    public function getThumbnailLink(string $size);
 
     /**
      * Returns the physical location of the thumbnail file with the given size.
      *
-     * @param string $size
      * @return string
      */
-    public function getThumbnailLocation($size);
+    public function getThumbnailLocation(string $size);
 
     /**
      * Returns the available thumbnail sizes.