Clean up *.DS_Store files and prevent them from being deployed

See https://www.woltlab.com/community/thread/315887/

Author: dtdesign

com.woltlab.wcf/package.xml

@@ -95,6 +95,7 @@ tar cvf com.woltlab.wcf/files_pre_check.tar -C wcfsetup/install/files/ \
 		<instruction type="userOption"/>
 
 		<instruction type="script">acp/update_com.woltlab.wcf_6.2_userCoverPhoto.php</instruction>
+		<instruction type="script">acp/update_com.woltlab.wcf_6.2_cleanUpDsStore.php</instruction>
 	</instructions>
 
 	<instructions type="update" fromversion="6.2.0 RC 2">

wcfsetup/install/files/acp/update_com.woltlab.wcf_6.2_cleanUpDsStore.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace wcf\acp;
+
+use wcf\system\application\ApplicationHandler;
+use wcf\system\WCF;
+
+// Purges any `.DS_Store` (or derivates) files that had been accidentially
+// deployed in the past. The `Installer` class was also modified to filter out
+// these files in the future.
+
+$sql = "SELECT  *
+        FROM    wcf1_package_installation_file_log
+        WHERE   filename LIKE ?";
+$statement = WCF::getDB()->prepare($sql);
+$statement->execute(['%.DS_Store']);
+
+while ($row = $statement->fetchArray()) {
+    $application = ApplicationHandler::getInstance()->getApplication($row['application']);
+    \assert($application !== null);
+
+    $pathname = \WCF_DIR . $application->getPackage()->packageDir . $row['filename'];
+    if (\file_exists($pathname)) {
+        \unlink($pathname);
+    }
+}
+
+$sql = "DELETE FROM wcf1_package_installation_file_log
+        WHERE       filename LIKE ?";
+$statement = WCF::getDB()->prepare($sql);
+$statement->execute(['%.DS_Store']);

wcfsetup/install/files/lib/system/setup/Installer.class.php

@@ -150,6 +150,10 @@ protected function install()
                     // remove trailing slash
                     $directories[] = FileUtil::removeTrailingSlash($file['filename']);
                 } else {
+                    if (\str_ends_with($file['filename'], '.DS_Store')) {
+                        continue;
+                    }
+
                     $files[$index] = $file['filename'];
                 }
             }