Implement a command to register user profile visitors (#6434)

* Implement a command to register user profile visitors

* Rename the command and unify the parameters

---------

Co-authored-by: Alexander Ebert <ebert@woltlab.com>

Author: Cyperghost

wcfsetup/install/files/lib/command/user/profile/TrackUserProfileVisitor.class.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace wcf\command\user\profile;
+
+use wcf\data\user\User;
+use wcf\system\WCF;
+
+/**
+ * Tracks a visit to a user profile, updating the time if the visitor is already
+ * known.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.3
+ */
+final class TrackUserProfileVisitor
+{
+    public function __construct(
+        private readonly User $user,
+        private readonly User $target,
+        private readonly int $time
+    ) {}
+
+    public function __invoke(): void
+    {
+        $sql = "INSERT INTO             wcf1_user_profile_visitor
+                                        (ownerID, userID, time)
+                VALUES                  (?, ?, ?)
+                ON DUPLICATE KEY UPDATE time = VALUES(time)";
+        $statement = WCF::getDB()->prepare($sql);
+        $statement->execute([
+            $this->target->userID,
+            $this->user->userID,
+            $this->time,
+        ]);
+    }
+}

wcfsetup/install/files/lib/data/user/profile/visitor/UserProfileVisitorAction.class.php

@@ -2,6 +2,7 @@
 
 namespace wcf\data\user\profile\visitor;
 
+use wcf\command\user\profile\TrackUserProfileVisitor;
 use wcf\data\AbstractDatabaseObjectAction;
 use wcf\data\IGroupedUserListAction;
 use wcf\data\user\UserProfile;
@@ -95,18 +96,21 @@ public function getGroupedUserList()
      * Inserts a new visitor if it does not already exist, or updates it if it does.
      * @return void
      * @since       5.2
+     *
+     * @deprecated 6.3 use the `RegisterUserProfileVisitor` command instead.
      */
     public function registerVisitor()
     {
-        $sql = "INSERT INTO             wcf1_user_profile_visitor
-                                        (ownerID, userID, time)
-                VALUES                  (?, ?, ?)
-                ON DUPLICATE KEY UPDATE time = VALUES(time)";
-        $statement = WCF::getDB()->prepare($sql);
-        $statement->execute([
-            $this->parameters['data']['ownerID'],
-            $this->parameters['data']['userID'],
-            $this->parameters['data']['time'] ?? TIME_NOW,
-        ]);
+        $user = UserProfileRuntimeCache::getInstance()->getObject($this->parameters['data']['userID']);
+        \assert($user !== null);
+
+        $target = UserProfileRuntimeCache::getInstance()->getObject($this->parameters['data']['ownerID']);
+        \assert($target !== null);
+
+        (new TrackUserProfileVisitor(
+            $user->getDecoratedObject(),
+            $target->getDecoratedObject(),
+            $this->parameters['data']['time'] ?? TIME_NOW
+        ))();
     }
 }

wcfsetup/install/files/lib/page/UserPage.class.php

@@ -2,13 +2,13 @@
 
 namespace wcf\page;
 
+use wcf\command\user\profile\TrackUserProfileVisitor;
 use wcf\data\object\type\ObjectType;
 use wcf\data\object\type\ObjectTypeCache;
 use wcf\data\user\cover\photo\UserCoverPhoto;
 use wcf\data\user\follow\UserFollowerList;
 use wcf\data\user\follow\UserFollowingList;
 use wcf\data\user\group\UserGroup;
-use wcf\data\user\profile\visitor\UserProfileVisitorAction;
 use wcf\data\user\profile\visitor\UserProfileVisitorList;
 use wcf\data\user\UserEditor;
 use wcf\data\user\UserProfile;
@@ -207,12 +207,7 @@ public function show()
             // save visitor
             /** @noinspection PhpUndefinedFieldInspection */
             if (PROFILE_ENABLE_VISITORS && WCF::getUser()->userID && !WCF::getUser()->canViewOnlineStatus) {
-                (new UserProfileVisitorAction([], 'registerVisitor', [
-                    'data' => [
-                        'ownerID' => $this->user->userID,
-                        'userID' => WCF::getUser()->userID,
-                    ],
-                ]))->executeAction();
+                (new TrackUserProfileVisitor(WCF::getUser(), $this->user->getDecoratedObject(), \TIME_NOW))();
             }
         }