Fix duplicate items in bulk interaction context menu

Author: BurntimeX

ts/WoltLabSuite/Core/Component/GridView.ts

@@ -12,6 +12,7 @@ import { getRows } from "../Api/Gridviews/GetRows";
 import { getBulkContextMenuOptions } from "../Api/Interactions/GetBulkContextMenuOptions";
 import DomChangeListener from "../Dom/Change/Listener";
 import DomUtil from "../Dom/Util";
+import { promiseMutex } from "../Helper/PromiseMutex";
 import { wheneverFirstSeen } from "../Helper/Selector";
 import UiDropdownSimple from "../Ui/Dropdown/Simple";
 import { State, StateChangeCause } from "./GridView/State";
@@ -117,9 +118,10 @@ export class GridView {
     state.addEventListener("grid-view:change", (event) => {
       void this.#loadRows(event.detail.source);
     });
-    state.addEventListener("grid-view:get-bulk-interactions", (event) => {
-      void this.#loadBulkInteractions(event.detail.objectIds);
-    });
+    state.addEventListener(
+      "grid-view:get-bulk-interactions",
+      promiseMutex((event) => this.#loadBulkInteractions(event.detail.objectIds)),
+    );
 
     return state;
   }

ts/WoltLabSuite/Core/Component/GridView/Selection.ts

@@ -247,6 +247,10 @@ export class Selection extends EventTarget {
         this.#bulkInteractionsPlaceholder.remove();
       }
 
+      while (lastDivider.previousElementSibling !== null) {
+        lastDivider.previousElementSibling.remove();
+      }
+
       menu.prepend(fragment);
 
       this.#initBulkInteractions();

ts/WoltLabSuite/Core/Component/ListView.ts

@@ -16,6 +16,7 @@ import { wheneverFirstSeen } from "../Helper/Selector";
 import UiDropdownSimple from "../Ui/Dropdown/Simple";
 import { getItem } from "../Api/ListViews/GetItem";
 import { getBulkContextMenuOptions } from "../Api/Interactions/GetBulkContextMenuOptions";
+import { promiseMutex } from "../Helper/PromiseMutex";
 
 export class ListView {
   readonly #viewClassName: string;
@@ -120,9 +121,10 @@ export class ListView {
     state.addEventListener("list-view:change", (event) => {
       void this.#loadItems(event.detail.source);
     });
-    state.addEventListener("list-view:get-bulk-interactions", (event) => {
-      void this.#loadBulkInteractions(event.detail.objectIds);
-    });
+    state.addEventListener(
+      "list-view:get-bulk-interactions",
+      promiseMutex((event) => this.#loadBulkInteractions(event.detail.objectIds)),
+    );
 
     return state;
   }

ts/WoltLabSuite/Core/Component/ListView/Selection.ts

@@ -247,6 +247,10 @@ export class Selection extends EventTarget {
         this.#bulkInteractionsPlaceholder.remove();
       }
 
+      while (lastDivider.previousElementSibling !== null) {
+        lastDivider.previousElementSibling.remove();
+      }
+
       menu.prepend(fragment);
 
       this.#initBulkInteractions();