Skip to content

Commit 83e1b69

Browse files
authored
Merge pull request #6573 from WoltLab/62-selection-bar-view-transition
Remove the view transition from list / grid views
2 parents ddadc0b + e56e600 commit 83e1b69

File tree

4 files changed

+9
-62
lines changed

4 files changed

+9
-62
lines changed

ts/WoltLabSuite/Core/Component/GridView/Selection.ts

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -175,24 +175,11 @@ export class Selection extends EventTarget {
175175
this.dispatchEvent(new CustomEvent("grid-view:update-selection"));
176176

177177
if (selectedIds.length === 0) {
178-
if ("startViewTransition" in document) {
179-
document.startViewTransition(() => {
180-
this.#selectionBar!.hidden = true;
181-
});
182-
} else {
183-
this.#selectionBar.hidden = true;
184-
}
185-
178+
this.#selectionBar.hidden = true;
186179
return;
187180
}
188181

189-
if ("startViewTransition" in document) {
190-
document.startViewTransition(() => {
191-
this.#selectionBar!.hidden = false;
192-
});
193-
} else {
194-
this.#selectionBar.hidden = false;
195-
}
182+
this.#selectionBar.hidden = false;
196183

197184
this.#bulkInteractionButton!.textContent = getPhrase("wcf.clipboard.button.numberOfSelectedItems", {
198185
numberOfSelectedItems: selectedIds.length,

ts/WoltLabSuite/Core/Component/ListView/Selection.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -175,24 +175,12 @@ export class Selection extends EventTarget {
175175
this.dispatchEvent(new CustomEvent("list-view:update-selection"));
176176

177177
if (selectedIds.length === 0) {
178-
if ("startViewTransition" in document) {
179-
document.startViewTransition(() => {
180-
this.#selectionBar!.hidden = true;
181-
});
182-
} else {
183-
this.#selectionBar.hidden = true;
184-
}
185-
178+
this.#selectionBar.hidden = true;
186179
return;
187180
}
188181

189-
if ("startViewTransition" in document) {
190-
document.startViewTransition(() => {
191-
this.#selectionBar!.hidden = false;
192-
});
193-
} else {
194-
this.#selectionBar.hidden = false;
195-
}
182+
this.#selectionBar.hidden = false;
183+
196184
this.#bulkInteractionButton!.textContent = getPhrase("wcf.clipboard.button.numberOfSelectedItems", {
197185
numberOfSelectedItems: selectedIds.length,
198186
});

wcfsetup/install/files/js/WoltLabSuite/Core/Component/GridView/Selection.js

Lines changed: 2 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wcfsetup/install/files/js/WoltLabSuite/Core/Component/ListView/Selection.js

Lines changed: 2 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)