Add per-field default sort order to list view sort fields

`ListViewSortField` now accepts a `defaultSortOrder` argument (ASC or DESC). When the user switches to a different sort field via the sorting dropdown, the field's default sort order is applied instead of always defaulting to ASC.

Author: BurntimeX

com.woltlab.wcf/templates/shared_listView.tpl

@@ -50,7 +50,7 @@
 								<ul class="dropdownMenu" id="{$view->getID()}_sorting">
 									{foreach from=$view->getAvailableSortFields() item='sortField'}
 										<li>
-											<button type="button" class="listView__sorting__button" data-sort-id="{$sortField->id}">
+											<button type="button" class="listView__sorting__button" data-sort-id="{$sortField->id}" data-default-sort-order="{$sortField->defaultSortOrder}">
 												{unsafe:$sortField}
 											</button>
 										</li>

ts/WoltLabSuite/Core/Component/ListView/Sorting.ts

@@ -32,7 +32,7 @@ export class Sorting extends EventTarget {
 
     this.#dropdownMenu?.querySelectorAll<HTMLElement>("[data-sort-id]").forEach((element) => {
       element.addEventListener("click", () => {
-        this.#sort(element.dataset.sortId!);
+        this.#sort(element.dataset.sortId!, element.dataset.defaultSortOrder ?? "ASC");
       });
     });
 
@@ -79,12 +79,12 @@ export class Sorting extends EventTarget {
     });
   }
 
-  #sort(sortField: string): void {
-    if (this.#sortField == sortField && this.#sortOrder == "ASC") {
-      this.#sortOrder = "DESC";
+  #sort(sortField: string, defaultSortOrder: string): void {
+    if (this.#sortField === sortField) {
+      this.#sortOrder = this.#sortOrder === "ASC" ? "DESC" : "ASC";
     } else {
       this.#sortField = sortField;
-      this.#sortOrder = "ASC";
+      this.#sortOrder = defaultSortOrder;
     }
 
     this.#renderActiveSorting();

wcfsetup/install/files/js/WoltLabSuite/Core/Component/ListView/Sorting.js

@@ -17,8 +17,13 @@ final class ListViewSortField implements \Stringable
     public function __construct(
         public readonly string $id,
         public readonly string $languageItem,
-        public readonly string $sortByDatabaseColumn = ''
-    ) {}
+        public readonly string $sortByDatabaseColumn = '',
+        public readonly string $defaultSortOrder = 'ASC',
+    ) {
+        if ($this->defaultSortOrder !== 'ASC' && $this->defaultSortOrder !== 'DESC') {
+            throw new \InvalidArgumentException("Invalid value '{$this->defaultSortOrder}' as default sort order given.");
+        }
+    }
 
     #[\Override]
     public function __toString(): string

wcfsetup/install/files/lib/system/listView/ListViewSortField.class.php

@@ -35,13 +35,13 @@ class ArticleListView extends AbstractListView
     public function __construct()
     {
         $this->addAvailableSortFields([
-            new ListViewSortField('time', 'wcf.global.date'),
+            new ListViewSortField('time', 'wcf.global.date', defaultSortOrder: 'DESC'),
             new ListViewSortField('title', 'wcf.global.title', 'title'),
-            new ListViewSortField('views', 'wcf.article.sortField.views'),
+            new ListViewSortField('views', 'wcf.article.sortField.views', defaultSortOrder: 'DESC'),
         ]);
         if (\MODULE_LIKE) {
             $this->addAvailableSortFields([
-                new ListViewSortField('cumulativeLikes', 'wcf.like.cumulativeLikes'),
+                new ListViewSortField('cumulativeLikes', 'wcf.like.cumulativeLikes', defaultSortOrder: 'DESC'),
             ]);
         }
         $this->addAvailableFilters([

wcfsetup/install/files/lib/system/listView/user/ArticleListView.class.php

@@ -33,10 +33,10 @@ public function __construct()
     {
         $this->addAvailableSortFields([
             new ListViewSortField('username', 'wcf.user.sortField.username'),
-            new ListViewSortField('registrationDate', 'wcf.user.sortField.registrationDate'),
-            new ListViewSortField('activityPoints', 'wcf.user.sortField.activityPoints'),
-            new ListViewSortField('likesReceived', 'wcf.user.sortField.likesReceived'),
-            new ListViewSortField('lastActivityTime', 'wcf.user.sortField.lastActivityTime'),
+            new ListViewSortField('registrationDate', 'wcf.user.sortField.registrationDate', defaultSortOrder: 'DESC'),
+            new ListViewSortField('activityPoints', 'wcf.user.sortField.activityPoints', defaultSortOrder: 'DESC'),
+            new ListViewSortField('likesReceived', 'wcf.user.sortField.likesReceived', defaultSortOrder: 'DESC'),
+            new ListViewSortField('lastActivityTime', 'wcf.user.sortField.lastActivityTime', defaultSortOrder: 'DESC'),
         ]);
 
         $this->addAvailableFilters([