Move the check whether an object is deactivated/activated from the command to the caller of the command.

Author: Cyperghost

wcfsetup/install/files/lib/command/ad/DisableAd.class.php

@@ -23,10 +23,6 @@ public function __construct(
 
     public function __invoke(): void
     {
-        if ($this->ad->isDisabled) {
-            return;
-        }
-
         (new AdEditor($this->ad))->update([
             'isDisabled' => 1,
         ]);

wcfsetup/install/files/lib/command/ad/EnableAd.class.php

@@ -23,10 +23,6 @@ public function __construct(
 
     public function __invoke(): void
     {
-        if (!$this->ad->isDisabled) {
-            return;
-        }
-
         (new AdEditor($this->ad))->update([
             'isDisabled' => 0,
         ]);

wcfsetup/install/files/lib/command/bbcode/media/provider/DisableBBCodeMediaProvider.class.php

@@ -21,10 +21,6 @@ public function __construct(private readonly BBCodeMediaProvider $mediaProvider)
 
     public function __invoke(): void
     {
-        if ($this->mediaProvider->isDisabled) {
-            return;
-        }
-
         (new BBCodeMediaProviderEditor($this->mediaProvider))->update([
             'isDisabled' => 1,
         ]);

wcfsetup/install/files/lib/command/bbcode/media/provider/EnableBBCodeMediaProvider.class.php

@@ -21,10 +21,6 @@ public function __construct(private readonly BBCodeMediaProvider $mediaProvider)
 
     public function __invoke(): void
     {
-        if (!$this->mediaProvider->isDisabled) {
-            return;
-        }
-
         (new BBCodeMediaProviderEditor($this->mediaProvider))->update([
             'isDisabled' => 0,
         ]);

wcfsetup/install/files/lib/command/box/DisableBox.class.php

@@ -21,10 +21,6 @@ public function __construct(private readonly Box $box) {}
 
     public function __invoke(): void
     {
-        if ($this->box->isDisabled) {
-            return;
-        }
-
         (new BoxEditor($this->box))->update([
             'isDisabled' => 1,
         ]);

wcfsetup/install/files/lib/command/box/EnableBox.class.php

@@ -21,10 +21,6 @@ public function __construct(private readonly Box $box) {}
 
     public function __invoke(): void
     {
-        if (!$this->box->isDisabled) {
-            return;
-        }
-
         (new BoxEditor($this->box))->update([
             'isDisabled' => 0,
         ]);

wcfsetup/install/files/lib/command/captcha/question/DisableCaptchaQuestion.class.php

@@ -23,10 +23,6 @@ public function __construct(
 
     public function __invoke(): void
     {
-        if ($this->captchaQuestion->isDisabled) {
-            return;
-        }
-
         (new CaptchaQuestionEditor($this->captchaQuestion))->update([
             'isDisabled' => 1,
         ]);

wcfsetup/install/files/lib/command/captcha/question/EnableCaptchaQuestion.class.php

@@ -23,10 +23,6 @@ public function __construct(
 
     public function __invoke(): void
     {
-        if (!$this->captchaQuestion->isDisabled) {
-            return;
-        }
-
         (new CaptchaQuestionEditor($this->captchaQuestion))->update([
             'isDisabled' => 0,
         ]);

wcfsetup/install/files/lib/command/contact/option/DisableContactOption.class.php

@@ -23,10 +23,6 @@ public function __construct(
 
     public function __invoke(): void
     {
-        if ($this->contactOption->isDisabled) {
-            return;
-        }
-
         (new ContactOptionEditor($this->contactOption))->update([
             'isDisabled' => 1,
         ]);

wcfsetup/install/files/lib/command/contact/option/EnableContactOption.class.php

@@ -23,10 +23,6 @@ public function __construct(
 
     public function __invoke(): void
     {
-        if (!$this->contactOption->isDisabled) {
-            return;
-        }
-
         (new ContactOptionEditor($this->contactOption))->update([
             'isDisabled' => 0,
         ]);