Merge pull request #6621 from WoltLab/62-resize-avatars

Graceful handling of undersized avatars

Author: dtdesign

wcfsetup/install/files/lib/system/worker/UserRebuildDataWorker.class.php

@@ -270,7 +270,7 @@ public function execute()
 
                 $width = $avatar->width;
                 $height = $avatar->height;
-                if ($width != $height) {
+                if ($width !== $height && $width >= UserAvatarFileProcessor::AVATAR_SIZE && $height >= UserAvatarFileProcessor::AVATAR_SIZE) {
                     // make avatar quadratic
                     // minimum size is 128x128, maximum size is 256x256
                     $width = $height = \min(
@@ -293,10 +293,13 @@ public function execute()
                     $thumbnail = null;
                 }
 
-                if (
-                    $width != UserAvatarFileProcessor::AVATAR_SIZE
-                    && $width != UserAvatarFileProcessor::AVATAR_SIZE_2X
-                ) {
+                if ((
+                    $width !== UserAvatarFileProcessor::AVATAR_SIZE
+                    && $width !== UserAvatarFileProcessor::AVATAR_SIZE_2X
+                ) || (
+                    $height !== UserAvatarFileProcessor::AVATAR_SIZE
+                    && $height !== UserAvatarFileProcessor::AVATAR_SIZE_2X
+                )) {
                     // resize avatar
                     $adapter = ImageHandler::getInstance()->getAdapter();