Add more missing type declaration

Author: BurntimeX

wcfsetup/install/files/lib/acp/page/LicensePage.class.php

@@ -443,15 +443,13 @@ static function ($packageUpdateServerID) use ($trustedServerIDs) {
      *
      * Stolen from PackageUpdateAction::canInstall()
      *
-     * @param int $packageUpdateID
-     * @param string|null $minVersion
      * @param string[] $installedPackages
      * @param string[] $excludedPackagesOfInstalledPackages
      * @return      string[][]
      */
     protected function canInstall(
-        $packageUpdateID,
-        $minVersion,
+        int $packageUpdateID,
+        ?string $minVersion,
         array &$installedPackages,
         array &$excludedPackagesOfInstalledPackages
     ) {

wcfsetup/install/files/lib/data/language/LanguageEditor.class.php

@@ -851,15 +851,13 @@ public function copy(Language $destination)
      * Updates the language items of a language category.
      *
      * @param array<string, string> $items
-     * @param LanguageCategory $category
-     * @param int $packageID
      * @param array<int, int> $useCustom
      * @return void
      */
     public function updateItems(
         array $items,
         LanguageCategory $category,
-        $packageID = PACKAGE_ID,
+        int $packageID = PACKAGE_ID,
         array $useCustom = []
     ) {
         if (empty($items)) {

wcfsetup/install/files/lib/data/package/update/PackageUpdateAction.class.php

@@ -277,15 +277,13 @@ static function ($packageUpdateServerID) use ($trustedServerIDs) {
      * Validates dependencies and exclusions of a package,
      * optionally limited by a minimum version number.
      *
-     * @param int $packageUpdateID
-     * @param string|null $minVersion
      * @param string[] $installedPackages
      * @param string[] $excludedPackagesOfInstalledPackages
      * @return string[][]
      */
     protected function canInstall(
-        $packageUpdateID,
-        $minVersion,
+        int $packageUpdateID,
+        ?string $minVersion,
         array &$installedPackages,
         array &$excludedPackagesOfInstalledPackages
     ) {

wcfsetup/install/files/lib/data/package/update/server/PackageUpdateServer.class.php

@@ -218,18 +218,13 @@ public function getAuthData()
 
     /**
      * Stores auth data for a package update server.
-     *
-     * @param int $packageUpdateServerID
-     * @param string $username
-     * @param string $password
-     * @param bool $saveCredentials
      */
     public static function storeAuthData(
-        $packageUpdateServerID,
-        $username,
+        int $packageUpdateServerID,
+        string $username,
         #[\SensitiveParameter]
-        $password,
-        $saveCredentials = false
+        string $password,
+        bool $saveCredentials = false
     ): void {
         $packageUpdateAuthData = @\unserialize(WCF::getSession()->getVar('packageUpdateAuthData'));
         if ($packageUpdateAuthData === null || !\is_array($packageUpdateAuthData)) {

wcfsetup/install/files/lib/data/user/User.class.php

@@ -142,12 +142,11 @@ public function __construct(null|string|int $id, ?array $row = null, ?DatabaseOb
     /**
      * Returns true if the given password is the correct password for this user.
      *
-     * @param string $password
      * @return bool password correct
      */
     public function checkPassword(
         #[\SensitiveParameter]
-        $password
+        string $password
     ) {
         $isValid = false;
 

wcfsetup/install/files/lib/system/bbcode/MessageParser.class.php

@@ -72,20 +72,15 @@ protected function init()
     /**
      * Parses a message.
      *
-     * @param string $text
-     * @param bool $enableSmilies
-     * @param bool $enableHtml
-     * @param bool $enableBBCodes
-     * @param bool $doKeywordHighlighting
      * @return string parsed message
      */
     #[\Override]
     public function parse(
-        $text,
-        $enableSmilies = true,
-        $enableHtml = false,
-        $enableBBCodes = true,
-        $doKeywordHighlighting = true
+        string $text,
+        bool $enableSmilies = true,
+        bool $enableHtml = false,
+        bool $enableBBCodes = true,
+        bool $doKeywordHighlighting = true
     ) {
         $this->cachedCodes = [];
         $this->message = $text;

wcfsetup/install/files/lib/system/database/Database.class.php

@@ -118,15 +118,15 @@ abstract class Database
      * @param mixed[] $defaultDriverOptions
      */
     public function __construct(
-        $host,
-        $user,
+        string $host,
+        string $user,
         #[\SensitiveParameter]
-        $password,
-        $database,
-        $port,
-        $failsafeTest = false,
-        $tryToCreateDatabase = false,
-        $defaultDriverOptions = []
+        string $password,
+        string $database,
+        int $port,
+        bool $failsafeTest = false,
+        bool $tryToCreateDatabase = false,
+        array $defaultDriverOptions = []
     ) {
         $this->host = $host;
         $this->port = $port;

wcfsetup/install/files/lib/system/email/transport/SmtpEmailTransport.class.php

@@ -78,12 +78,12 @@ final class SmtpEmailTransport implements IStatusReportingEmailTransport
      * @throws  \InvalidArgumentException
      */
     public function __construct(
-        $host = MAIL_SMTP_HOST,
-        $port = MAIL_SMTP_PORT,
-        $username = MAIL_SMTP_USER,
+        string $host = MAIL_SMTP_HOST,
+        int $port = MAIL_SMTP_PORT,
+        string $username = MAIL_SMTP_USER,
         #[\SensitiveParameter]
-        $password = MAIL_SMTP_PASSWORD,
-        $starttls = MAIL_SMTP_STARTTLS
+        string $password = MAIL_SMTP_PASSWORD,
+        string $starttls = MAIL_SMTP_STARTTLS
     ) {
         $this->host = StringUtil::trim($host);
         $this->port = \intval($port);

wcfsetup/install/files/lib/system/exception/AJAXException.class.php

@@ -55,21 +55,16 @@ class AJAXException extends LoggedException
     /**
      * Throws a JSON-encoded error message
      *
-     * @param string $message
-     * @param int $errorType
-     * @param string $stacktrace
      * @param mixed[] $returnValues
-     * @param string $exceptionID
-     * @param \Exception|\Throwable $previous
      * @param array<string, mixed> $extraInformation
      */
     public function __construct(
-        $message,
-        $errorType = self::INTERNAL_ERROR,
-        $stacktrace = null,
-        $returnValues = [],
-        $exceptionID = '',
-        $previous = null,
+        string $message,
+        int $errorType = self::INTERNAL_ERROR,
+        ?string $stacktrace = null,
+        array $returnValues = [],
+        string $exceptionID = '',
+        null|\Exception|\Throwable $previous = null,
         array $extraInformation = [],
     ) {
         if ($stacktrace === null) {

wcfsetup/install/files/lib/system/exception/ErrorException.class.php

@@ -19,21 +19,13 @@ class ErrorException extends SystemException
      */
     protected $severity;
 
-    /**
-     * @param string $message
-     * @param int $code
-     * @param int $severity
-     * @param string $filename
-     * @param int $lineno
-     * @param ?\Exception $previous
-     */
     public function __construct(
-        $message = "",
-        $code = 0,
-        $severity = 1,
-        $filename = __FILE__,
-        $lineno = __LINE__,
-        $previous = null
+        string $message = "",
+        int $code = 0,
+        int $severity = 1,
+        string $filename = __FILE__,
+        int $lineno = __LINE__,
+        ?\Exception $previous = null
     ) {
         parent::__construct($message, $code, "", $previous);