Apply suggestions from code review

Cyperghost · BurntimeX · web-flow · commit ecbba1b03e3c · 2025-08-13T13:39:39.000+02:00
Co-authored-by: Marcel Werk &lt;burntime@woltlab.com&gt;
diff --git a/wcfsetup/install/files/lib/command/ad/DisableAd.class.php b/wcfsetup/install/files/lib/command/ad/DisableAd.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disable an ad.
+ * Disables an ad.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/ad/EnableAd.class.php b/wcfsetup/install/files/lib/command/ad/EnableAd.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enable an ad.
+ * Enables an ad.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/box/DisableBox.class.php b/wcfsetup/install/files/lib/command/box/DisableBox.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables a box.
+ * Disables a box.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/captcha/question/DisableCaptchaQuestion.class.php b/wcfsetup/install/files/lib/command/captcha/question/DisableCaptchaQuestion.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given captcha question.
+ * Disables a captcha question.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/captcha/question/EnableCaptchaQuestion.class.php b/wcfsetup/install/files/lib/command/captcha/question/EnableCaptchaQuestion.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given captcha question.
+ * Enables a captcha question.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/contact/option/DisableContactOption.class.php b/wcfsetup/install/files/lib/command/contact/option/DisableContactOption.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disable the contact option.
+ * Disables a contact option.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/contact/option/EnableContactOption.class.php b/wcfsetup/install/files/lib/command/contact/option/EnableContactOption.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the contact option.
+ * Enables a contact option.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/contact/recipient/DisableContactRecipient.class.php b/wcfsetup/install/files/lib/command/contact/recipient/DisableContactRecipient.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the contact recipient.
+ * Disables a contact recipient.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/contact/recipient/EnableContactRecipient.class.php b/wcfsetup/install/files/lib/command/contact/recipient/EnableContactRecipient.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the contact recipient.
+ * Enables a contact recipient.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/cronjob/DisableCronjob.class.php b/wcfsetup/install/files/lib/command/cronjob/DisableCronjob.class.php
@@ -9,7 +9,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given cronjob.
+ * Disables a cronjob.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/cronjob/EnableCronjob.class.php b/wcfsetup/install/files/lib/command/cronjob/EnableCronjob.class.php
@@ -9,7 +9,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given cronjob.
+ * Enables a cronjob.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/language/DisableLanguage.class.php b/wcfsetup/install/files/lib/command/language/DisableLanguage.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given language.
+ * Disables a language.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/language/EnableLanguage.class.php b/wcfsetup/install/files/lib/command/language/EnableLanguage.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given language.
+ * Enables a language.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/notice/DisableNotice.class.php b/wcfsetup/install/files/lib/command/notice/DisableNotice.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given notice.
+ * Disables a notice.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/notice/EnableNotice.class.php b/wcfsetup/install/files/lib/command/notice/EnableNotice.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given notice.
+ * Enables a notice.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/package/update/server/DisablePackageUpdateServer.class.php b/wcfsetup/install/files/lib/command/package/update/server/DisablePackageUpdateServer.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given package update server.
+ * Disables a package update server.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/package/update/server/EnablePackageUpdateServer.class.php b/wcfsetup/install/files/lib/command/package/update/server/EnablePackageUpdateServer.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given package update server.
+ * Enables a package update server.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/page/DisablePage.class.php b/wcfsetup/install/files/lib/command/page/DisablePage.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given page.
+ * Disables a page.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/page/EnablePage.class.php b/wcfsetup/install/files/lib/command/page/EnablePage.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given page.
+ * Enables a page.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/reaction/type/EnableReactionType.class.php b/wcfsetup/install/files/lib/command/reaction/type/EnableReactionType.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enable a reaction type.
+ * Enables a reaction type.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/style/DisableStyle.class.php b/wcfsetup/install/files/lib/command/style/DisableStyle.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Disables the given style.
+ * Disables a style.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/style/EnableStyle.class.php b/wcfsetup/install/files/lib/command/style/EnableStyle.class.php
@@ -8,7 +8,7 @@
 use wcf\system\event\EventHandler;
 
 /**
- * Enables the given style.
+ * Enables a style.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/trophy/DisableTrophy.class.php b/wcfsetup/install/files/lib/command/trophy/DisableTrophy.class.php
@@ -12,7 +12,7 @@
 use wcf\system\WCF;
 
 /**
- * Disables the given trophy.
+ * Disables a trophy.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/command/trophy/EnableTrophy.class.php b/wcfsetup/install/files/lib/command/trophy/EnableTrophy.class.php
@@ -12,7 +12,7 @@
 use wcf\system\WCF;
 
 /**
- * Enables the given trophy.
+ * Enables a trophy.
  *
  * @author Olaf Braun
  * @copyright 2001-2025 WoltLab GmbH
diff --git a/wcfsetup/install/files/lib/system/endpoint/controller/core/boxes/DisableBox.class.php b/wcfsetup/install/files/lib/system/endpoint/controller/core/boxes/DisableBox.class.php
@@ -28,7 +28,7 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
     {
         $box = Helper::fetchObjectFromRequestParameter($variables['id'], Box::class);
 
-        $this->assertBoxCanBeDisabled($box);
+        $this->assertBoxCanBeDisabled();
 
         if (!$box->isDisabled) {
             (new \wcf\command\box\DisableBox($box))();

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use wcf\system\event\EventHandler;`
`9`	`9`
`10`	`10`	`/**`
`11`		`- * Disable an ad.`
	`11`	`+ * Disables an ad.`
`12`	`12`	`*`
`13`	`13`	`* @author Olaf Braun`
`14`	`14`	`* @copyright 2001-2025 WoltLab GmbH`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`use wcf\system\event\EventHandler;`
`10`	`10`
`11`	`11`	`/**`
`12`		`- * Disables the given cronjob.`
	`12`	`+ * Disables a cronjob.`
`13`	`13`	`*`
`14`	`14`	`* @author Olaf Braun`
`15`	`15`	`* @copyright 2001-2025 WoltLab GmbH`