Skip to content

Align the quote buttons directly below the selected text#6269

Merged
Cyperghost merged 2 commits into6.2from
6.2-quote-alignment
Apr 22, 2025
Merged

Align the quote buttons directly below the selected text#6269
Cyperghost merged 2 commits into6.2from
6.2-quote-alignment

Conversation

@Cyperghost
Copy link
Copy Markdown
Contributor

Closes #6268

@Cyperghost Cyperghost requested a review from BurntimeX April 16, 2025 08:04
@BurntimeX BurntimeX requested a review from dtdesign April 16, 2025 09:41
Copy link
Copy Markdown
Member

@dtdesign dtdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand the motivation behind this change. Why don’t you pass { horizontal: "center" } as the 3rd parameter to UiAlignment.set() instead which does exactly the same?

@Cyperghost
Copy link
Copy Markdown
Contributor Author

I don’t understand the motivation behind this change. Why don’t you pass { horizontal: "center" } as the 3rd parameter to UiAlignment.set() instead which does exactly the same?

Not exactly, we cannot pass a direct a text reference to UiAlignment, only HTMLElement.
That is, if the selected text is at the top of a p that contains a long text, the button will not be displayed directly below the selected text.
Which is the case in version 6.1.

Comment thread ts/WoltLabSuite/Core/Component/Quote/Message.ts Outdated
@Cyperghost Cyperghost requested a review from dtdesign April 17, 2025 13:20
@Cyperghost Cyperghost merged commit 7398733 into 6.2 Apr 22, 2025
8 checks passed
@Cyperghost Cyperghost deleted the 6.2-quote-alignment branch April 22, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants