Use time() instead of TIME_NOW#6284
Closed
ChristopherWalz wants to merge 1 commit intoWoltLab:6.1from
Closed
Conversation
Member
|
I can see the point you’re trying to make but I don’t understand what kind of problem is being solved here. Let’s imagine that the email spends some time in the queue of your mail server for whatever reason. Your timestamp might now be more recent, but when the email is received it is still behind some time. This is especially true for email servers that are required to be tolerant about reaching the destination server and usually use an exponential back-off to delay the delivery. PS: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending hundreds of emails in a long running task might take some time (depending on the provider and other work in the task) which could result in some emails having an "old" timestamp. An email might arrive at 12:53 (actual time) but have a timestamp of 12:50, because of the long running task.