Skip to content

Use time() instead of TIME_NOW#6284

Closed
ChristopherWalz wants to merge 1 commit intoWoltLab:6.1from
ChristopherWalz:patch-4
Closed

Use time() instead of TIME_NOW#6284
ChristopherWalz wants to merge 1 commit intoWoltLab:6.1from
ChristopherWalz:patch-4

Conversation

@ChristopherWalz
Copy link
Copy Markdown
Contributor

Sending hundreds of emails in a long running task might take some time (depending on the provider and other work in the task) which could result in some emails having an "old" timestamp. An email might arrive at 12:53 (actual time) but have a timestamp of 12:50, because of the long running task.

@dtdesign
Copy link
Copy Markdown
Member

dtdesign commented May 8, 2025

I can see the point you’re trying to make but I don’t understand what kind of problem is being solved here. Let’s imagine that the email spends some time in the queue of your mail server for whatever reason. Your timestamp might now be more recent, but when the email is received it is still behind some time.

This is especially true for email servers that are required to be tolerant about reaching the destination server and usually use an exponential back-off to delay the delivery.

PS: $this->date = new \DateTime('now'); would be more reasonable.

@dtdesign dtdesign closed this May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants