Merged
Conversation
dtdesign
requested changes
Jun 25, 2025
dtdesign
requested changes
Jun 29, 2025
Member
dtdesign
left a comment
dtdesign
left a comment
There was a problem hiding this comment.
I don’t like the name of the phrases at all because they align with nothing. Either use camelCase like we always do or preserve the uppercase style of their identifiers. Lowercasing it but keeping the underscores is highly inconsistent.
Considering that we have traditionally been mapping phrases using lookup tables (like it is the case right now), you should stick to camelCase for the phrase identifiers.
Only display external content in Fancybox after confirmation by the user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6360