Merged
Conversation
These fields aren’t used anyway.
It can be completely replaced by the existing `render-quote` endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the fetching and the preparation of the quoted message back into the quote handler, enabling implementations to have a much greater flexibility over the object creation and validation. Furthermore this uses the
classNameproperty as an indicator for legacy implementations to allow for a much cleaner transition once we drop support for it.There have also been some fixes in regards to comments authored by guests and implementations that do not support full quotes at all.
One side-effect of this PR is that the endpoint for the message author had been removed. Its logic was quite similar to the endpoint to render quotes and with a small modification it was possible to merge them.
Existing implementations for the API of 6.1 or earlier remain fully compatible without any changes required, although it is strongly recommended to migrate to the updated API.