Skip to content

Show absolute path to WSC installation in path selection overlay on DevtoolsProjectListPage #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fighter456 wants to merge 3 commits into from
Closed

Show absolute path to WSC installation in path selection overlay on DevtoolsProjectListPage #6515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d04be1
Add placeholder to projectQuickSetupPath input
Fighter456 Nov 10, 2025
f0aefdc
Make `wcfDir` available in template
Fighter456 Nov 10, 2025
74742f8
Fix indentation
Fighter456 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wcfsetup/install/files/acp/templates/devtoolsProjectList.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<dl>
<dt>{lang}wcf.acp.devtools.project.quickSetup.path{/lang}</dt>
<dd>
<input type="text" name="projectQuickSetupPath" id="projectQuickSetupPath" class="long" />
<input type="text" name="projectQuickSetupPath" id="projectQuickSetupPath" class="long" placeholder="{unsafe:$wcfDir}" />
Copy link
Copy Markdown
Member

@dtdesign dtdesign Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you use unsafe: here?

Copy link
Copy Markdown
Contributor Author

@Fighter456 Fighter456 Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC I've copied it from another template. Not necessary at this point?

Copy link
Copy Markdown
Member

@dtdesign dtdesign Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general guideline: Never use unsafe: unless you actually need it. The performance gains are negligible but you risk malformed HTML or XSS. This also makes it much easier to test for security issues because in HTML any variable that is escaped before outputting is safe by definition.

<small>{lang}wcf.acp.devtools.project.quickSetup.path.description{/lang}</small>
</dd>
</dl>
Expand Down
11 changes: 11 additions & 0 deletions wcfsetup/install/files/lib/acp/page/DevtoolsProjectListPage.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use wcf\data\devtools\project\DevtoolsProjectList;
use wcf\page\SortablePage;
use wcf\system\WCF;

/**
* Shows a list of devtools projects.
Expand Down Expand Up @@ -51,4 +52,14 @@ class DevtoolsProjectListPage extends SortablePage
* @inheritDoc
*/
public $validSortFields = ['projectID', 'name', 'path'];

#[\Override]
public function assignVariables()
{
parent::assignVariables();

WCF::getTPL()->assign([
'wcfDir' => WCF_DIR,
]);
}
}