Skip to content

Improve performance of CheckSystemEnvironment middleware #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtdesign merged 2 commits into from
Feb 26, 2026
Merged

Improve performance of CheckSystemEnvironment middleware #6604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea304e0
Invert order of checks in `CheckSystemEnvironment`
TimWolla Feb 24, 2026
2a617c5
Fully qualify `\PHP_VERSION_ID` in `StatusMessageAcpDashboardBox`
TimWolla Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wcfsetup/install/files/lib/http/middleware/CheckSystemEnvironment.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ final class CheckSystemEnvironment implements MiddlewareInterface
*/
public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
{
if (!RequestHandler::getInstance()->isACPRequest()) {
// @phpstan-ignore smallerOrEqual.alwaysTrue, smallerOrEqual.alwaysTrue, booleanAnd.alwaysTrue
if (!(80100 <= \PHP_VERSION_ID && \PHP_VERSION_ID <= 80499)) {
// @phpstan-ignore smallerOrEqual.alwaysTrue, smallerOrEqual.alwaysTrue, booleanAnd.alwaysTrue
if (!(80100 <= \PHP_VERSION_ID && \PHP_VERSION_ID <= 80499)) {
if (!RequestHandler::getInstance()->isACPRequest()) {
return new HtmlResponse(
(new HtmlErrorRenderer())->render(
WCF::getLanguage()->getDynamicVariable('wcf.global.error.title'),
Expand Down
2 changes: 1 addition & 1 deletion wcfsetup/install/files/lib/system/acp/dashboard/box/StatusMessageAcpDashboardBox.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ private function getBasicMessages(): array
{
$messages = [];
// @phpstan-ignore smallerOrEqual.alwaysTrue, smallerOrEqual.alwaysTrue, booleanAnd.alwaysTrue
if (!(80100 <= PHP_VERSION_ID && PHP_VERSION_ID <= 80499)) {
if (!(80100 <= \PHP_VERSION_ID && \PHP_VERSION_ID <= 80499)) {
$messages[] = new StatusMessage(
StatusMessageType::Error,
WCF::getLanguage()->getDynamicVariable('wcf.global.incompatiblePhpVersion')
Expand Down