diff --git a/wcfsetup/install.php b/wcfsetup/install.php index b92950db948..cae78780667 100644 --- a/wcfsetup/install.php +++ b/wcfsetup/install.php @@ -1,4 +1,5 @@ assignment->getConditions(); foreach ($conditions as $condition) { - /** @noinspection PhpUndefinedMethodInspection */ $this->conditions[$condition->getObjectType()->conditiongroup][$condition->objectTypeID]->getProcessor()->setData($condition); } } diff --git a/wcfsetup/install/files/lib/action/AJAXInvokeAction.class.php b/wcfsetup/install/files/lib/action/AJAXInvokeAction.class.php index ea065c757c4..2496b3d7970 100644 --- a/wcfsetup/install/files/lib/action/AJAXInvokeAction.class.php +++ b/wcfsetup/install/files/lib/action/AJAXInvokeAction.class.php @@ -144,7 +144,6 @@ protected function invoke() // validate accessibility $className = $this->className; - /** @noinspection PhpUndefinedFieldInspection */ if (!\property_exists($className, 'allowInvoke') || !\in_array($this->actionName, $className::$allowInvoke)) { throw new PermissionDeniedException(); } diff --git a/wcfsetup/install/files/lib/action/AJAXProxyAction.class.php b/wcfsetup/install/files/lib/action/AJAXProxyAction.class.php index 09b62597dec..b4cd65b139e 100644 --- a/wcfsetup/install/files/lib/action/AJAXProxyAction.class.php +++ b/wcfsetup/install/files/lib/action/AJAXProxyAction.class.php @@ -99,7 +99,6 @@ protected function sendResponse() { // add benchmark and debug data if (ENABLE_BENCHMARK) { - /** @noinspection PhpUndefinedMethodInspection */ $this->response['benchmark'] = [ 'executionTime' => WCF::getBenchmark()->getExecutionTime() . 's', 'memoryUsage' => WCF::getBenchmark()->getMemoryUsage(), @@ -109,7 +108,6 @@ protected function sendResponse() ]; if (ENABLE_DEBUG_MODE) { - /** @noinspection PhpUndefinedMethodInspection */ $this->response['benchmark']['items'] = WCF::getBenchmark()->getItems(); } } diff --git a/wcfsetup/install/files/lib/action/PaypalCallbackAction.class.php b/wcfsetup/install/files/lib/action/PaypalCallbackAction.class.php index 7adf6d39dde..0e5b470d551 100644 --- a/wcfsetup/install/files/lib/action/PaypalCallbackAction.class.php +++ b/wcfsetup/install/files/lib/action/PaypalCallbackAction.class.php @@ -31,7 +31,6 @@ public function execute(): ResponseInterface $processor = null; try { // post back to paypal to validate - /** @noinspection PhpUnusedLocalVariableInspection */ $content = ''; try { $url = 'https://www.paypal.com/cgi-bin/webscr'; diff --git a/wcfsetup/install/files/lib/data/AbstractDatabaseObjectAction.class.php b/wcfsetup/install/files/lib/data/AbstractDatabaseObjectAction.class.php index 723550d8e51..f87c2125565 100644 --- a/wcfsetup/install/files/lib/data/AbstractDatabaseObjectAction.class.php +++ b/wcfsetup/install/files/lib/data/AbstractDatabaseObjectAction.class.php @@ -141,7 +141,6 @@ public function __construct(array $objects, $action, array $parameters = []) throw new SystemException('invalid value of parameter objects given'); } - /** @noinspection PhpVariableVariableInspection */ $this->objectIDs[] = $object->{$indexName}; } else { $this->objectIDs[] = $object; diff --git a/wcfsetup/install/files/lib/data/DatabaseObject.class.php b/wcfsetup/install/files/lib/data/DatabaseObject.class.php index 5bc2f040989..e8615ea41e4 100644 --- a/wcfsetup/install/files/lib/data/DatabaseObject.class.php +++ b/wcfsetup/install/files/lib/data/DatabaseObject.class.php @@ -229,7 +229,6 @@ public static function sort(&$objects, $sortBy, $sortOrder = 'ASC', $maintainInd { $sortArray = $objects2 = []; foreach ($objects as $idx => $obj) { - /** @noinspection PhpVariableVariableInspection */ $sortArray[$idx] = $obj->{$sortBy}; // array_multisort will drop index association if key is not a string diff --git a/wcfsetup/install/files/lib/data/TLegacyUserPropertyAccess.class.php b/wcfsetup/install/files/lib/data/TLegacyUserPropertyAccess.class.php index 41871540554..0ec4005d7c4 100644 --- a/wcfsetup/install/files/lib/data/TLegacyUserPropertyAccess.class.php +++ b/wcfsetup/install/files/lib/data/TLegacyUserPropertyAccess.class.php @@ -23,8 +23,6 @@ trait TLegacyUserPropertyAccess */ public function __get($name) { - /** @noinspection PhpUndefinedClassInspection */ - /** @noinspection PhpUndefinedMethodInspection */ $value = parent::__get($name); if ($value !== null) { return $value; @@ -36,7 +34,6 @@ public function __get($name) // in case any code should rely on directly accessing user properties, // refer them to the user profile object - /** @noinspection PhpVariableVariableInspection */ return $this->getUserProfile()->{$name}; } } diff --git a/wcfsetup/install/files/lib/data/TMultiCategoryObject.class.php b/wcfsetup/install/files/lib/data/TMultiCategoryObject.class.php index 47937c1f4f8..ae1fdffd462 100644 --- a/wcfsetup/install/files/lib/data/TMultiCategoryObject.class.php +++ b/wcfsetup/install/files/lib/data/TMultiCategoryObject.class.php @@ -69,7 +69,6 @@ public function getCategories() if (!empty($this->categoryIDs)) { foreach ($this->categoryIDs as $categoryID) { - /** @noinspection PhpUndefinedMethodInspection */ $this->categories[$categoryID] = $className::getCategory($categoryID); } } else { @@ -84,7 +83,6 @@ public function getCategories() $statement = WCF::getDB()->prepare($sql); $statement->execute([$this->getObjectID()]); while ($categoryID = $statement->fetchColumn()) { - /** @noinspection PhpUndefinedMethodInspection */ $this->categories[$categoryID] = $className::getCategory($categoryID); } } diff --git a/wcfsetup/install/files/lib/data/acp/session/log/ACPSessionLog.class.php b/wcfsetup/install/files/lib/data/acp/session/log/ACPSessionLog.class.php index 20f5fd3d76f..5aed9f21380 100644 --- a/wcfsetup/install/files/lib/data/acp/session/log/ACPSessionLog.class.php +++ b/wcfsetup/install/files/lib/data/acp/session/log/ACPSessionLog.class.php @@ -29,8 +29,6 @@ class ACPSessionLog extends DatabaseObject */ protected static $databaseTableIndexName = 'sessionLogID'; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * @inheritDoc */ diff --git a/wcfsetup/install/files/lib/data/ad/Ad.class.php b/wcfsetup/install/files/lib/data/ad/Ad.class.php index 7cf08340bee..bde22df25e1 100644 --- a/wcfsetup/install/files/lib/data/ad/Ad.class.php +++ b/wcfsetup/install/files/lib/data/ad/Ad.class.php @@ -47,9 +47,7 @@ public function getLocation() $objectType = ObjectTypeCache::getInstance()->getObjectType($this->objectTypeID); $location = WCF::getLanguage()->get('wcf.acp.ad.location.' . $objectType->objectType); - /** @noinspection PhpUndefinedFieldInspection */ if ($objectType->categoryname != 'com.woltlab.wcf.global') { - /** @noinspection PhpUndefinedFieldInspection */ $location = WCF::getLanguage()->get('wcf.acp.ad.location.category.' . $objectType->categoryname) . ': ' . $location; } diff --git a/wcfsetup/install/files/lib/data/article/ArticleAction.class.php b/wcfsetup/install/files/lib/data/article/ArticleAction.class.php index 51337b9c2e4..49053f3347b 100644 --- a/wcfsetup/install/files/lib/data/article/ArticleAction.class.php +++ b/wcfsetup/install/files/lib/data/article/ArticleAction.class.php @@ -104,7 +104,6 @@ public function create() if (!empty($this->parameters['content'])) { foreach ($this->parameters['content'] as $languageID => $content) { if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['content'] = $content['htmlInputProcessor']->getHtml(); } @@ -147,7 +146,6 @@ public function create() // save embedded objects if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['htmlInputProcessor']->setObjectID($articleContent->articleContentID); if (MessageEmbeddedObjectManager::getInstance()->registerObjects($content['htmlInputProcessor'])) { $articleContentEditor->update(['hasEmbeddedObjects' => 1]); @@ -206,7 +204,6 @@ public function update() foreach ($this->parameters['content'] as $languageID => $content) { if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['content'] = $content['htmlInputProcessor']->getHtml(); } @@ -282,7 +279,6 @@ public function update() // save embedded objects if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['htmlInputProcessor']->setObjectID($articleContent->articleContentID); if ($articleContent->hasEmbeddedObjects != MessageEmbeddedObjectManager::getInstance()->registerObjects($content['htmlInputProcessor'])) { $articleContentEditor->update(['hasEmbeddedObjects' => $articleContent->hasEmbeddedObjects ? 0 : 1]); diff --git a/wcfsetup/install/files/lib/data/article/CategoryArticleList.class.php b/wcfsetup/install/files/lib/data/article/CategoryArticleList.class.php index 83b8c23d8bb..0c7a9f05725 100644 --- a/wcfsetup/install/files/lib/data/article/CategoryArticleList.class.php +++ b/wcfsetup/install/files/lib/data/article/CategoryArticleList.class.php @@ -15,8 +15,6 @@ */ class CategoryArticleList extends AccessibleArticleList { - /** @noinspection PhpMissingParentConstructorInspection */ - /** * Creates a new CategoryArticleList object. * diff --git a/wcfsetup/install/files/lib/data/box/BoxAction.class.php b/wcfsetup/install/files/lib/data/box/BoxAction.class.php index aba512757c0..7cebe65121e 100644 --- a/wcfsetup/install/files/lib/data/box/BoxAction.class.php +++ b/wcfsetup/install/files/lib/data/box/BoxAction.class.php @@ -74,7 +74,6 @@ public function create() if (!empty($this->parameters['content'])) { foreach ($this->parameters['content'] as $languageID => $content) { if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['content'] = $content['htmlInputProcessor']->getHtml(); } @@ -90,7 +89,6 @@ public function create() // save embedded objects if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['htmlInputProcessor']->setObjectID($boxContent->boxContentID); if (MessageEmbeddedObjectManager::getInstance()->registerObjects($content['htmlInputProcessor'])) { $boxContentEditor->update(['hasEmbeddedObjects' => 1]); @@ -157,7 +155,6 @@ public function update() foreach ($this->parameters['content'] as $languageID => $content) { if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['content'] = $content['htmlInputProcessor']->getHtml(); } @@ -195,7 +192,6 @@ public function update() // save embedded objects if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['htmlInputProcessor']->setObjectID($boxContent->boxContentID); if ($boxContent->hasEmbeddedObjects != MessageEmbeddedObjectManager::getInstance()->registerObjects($content['htmlInputProcessor'])) { $boxContentEditor->update(['hasEmbeddedObjects' => $boxContent->hasEmbeddedObjects ? 0 : 1]); diff --git a/wcfsetup/install/files/lib/data/clipboard/item/ClipboardItemAction.class.php b/wcfsetup/install/files/lib/data/clipboard/item/ClipboardItemAction.class.php index 33d58ab2645..624c657a9eb 100644 --- a/wcfsetup/install/files/lib/data/clipboard/item/ClipboardItemAction.class.php +++ b/wcfsetup/install/files/lib/data/clipboard/item/ClipboardItemAction.class.php @@ -29,8 +29,6 @@ class ClipboardItemAction extends AbstractDatabaseObjectAction */ public $objectTypeID = 0; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * This is a heavily modified constructor which behaves differently from other DBOActions, * primarily because this class just masquerades as a regular DBOAction. diff --git a/wcfsetup/install/files/lib/data/like/LikeAction.class.php b/wcfsetup/install/files/lib/data/like/LikeAction.class.php index 6fae4c8495a..9b7e98c6e99 100644 --- a/wcfsetup/install/files/lib/data/like/LikeAction.class.php +++ b/wcfsetup/install/files/lib/data/like/LikeAction.class.php @@ -106,12 +106,10 @@ public function getLikeDetails() $values = []; if (!empty($data[Like::LIKE])) { $values[Like::LIKE] = new GroupedUserList(WCF::getLanguage()->get('wcf.like.details.like')); - /** @noinspection PhpUndefinedMethodInspection */ $values[Like::LIKE]->addUserIDs($data[Like::LIKE]); } if (!empty($data[Like::DISLIKE])) { $values[Like::DISLIKE] = new GroupedUserList(WCF::getLanguage()->get('wcf.like.details.dislike')); - /** @noinspection PhpUndefinedMethodInspection */ $values[Like::DISLIKE]->addUserIDs($data[Like::DISLIKE]); } @@ -300,12 +298,10 @@ public function getGroupedUserList() $values = []; if (!empty($data[Like::LIKE])) { $values[Like::LIKE] = new GroupedUserList(WCF::getLanguage()->get('wcf.like.details.like')); - /** @noinspection PhpUndefinedMethodInspection */ $values[Like::LIKE]->addUserIDs($data[Like::LIKE]); } if (!empty($data[Like::DISLIKE])) { $values[Like::DISLIKE] = new GroupedUserList(WCF::getLanguage()->get('wcf.like.details.dislike')); - /** @noinspection PhpUndefinedMethodInspection */ $values[Like::DISLIKE]->addUserIDs($data[Like::DISLIKE]); } diff --git a/wcfsetup/install/files/lib/data/media/MediaAction.class.php b/wcfsetup/install/files/lib/data/media/MediaAction.class.php index a60f73dce03..4b1b52776a4 100644 --- a/wcfsetup/install/files/lib/data/media/MediaAction.class.php +++ b/wcfsetup/install/files/lib/data/media/MediaAction.class.php @@ -50,7 +50,6 @@ public function validateUpload() $this->readBoolean('imagesOnly', true); $this->readInteger('categoryID', true); - /** @noinspection PhpUndefinedMethodInspection */ $this->parameters['__files']->validateFiles(new MediaUploadFileValidationStrategy($this->parameters['imagesOnly'])); if ($this->parameters['categoryID']) { @@ -77,7 +76,6 @@ public function upload() 'rotateImages' => true, ], $additionalData); - /** @noinspection PhpUndefinedMethodInspection */ $this->parameters['__files']->saveFiles($saveStrategy); /** @var Media[] $mediaFiles */ @@ -106,7 +104,6 @@ public function upload() } /** @var UploadFile[] $files */ - /** @noinspection PhpUndefinedMethodInspection */ $files = $this->parameters['__files']->getFiles(); foreach ($files as $file) { if ($file->getValidationErrorType()) { @@ -480,11 +477,9 @@ public function update() if (isset($this->parameters[$type])) { if (\is_array($this->parameters[$type])) { if (isset($this->parameters[$type][$language->languageID])) { - /** @noinspection PhpVariableVariableInspection */ ${$type} = $this->parameters[$type][$language->languageID]; } } else { - /** @noinspection PhpVariableVariableInspection */ ${$type} = $this->parameters[$type]; } } @@ -760,7 +755,6 @@ public function validateReplaceFile() $this->getSingleObject(); - /** @noinspection PhpUndefinedMethodInspection */ $this->parameters['__files']->validateFiles( new MediaReplaceUploadFileValidationStrategy($this->getSingleObject()->getDecoratedObject()) ); @@ -809,7 +803,6 @@ public function replaceFile() 'largeThumbnailHeight' => 0, ]); - /** @noinspection PhpUndefinedMethodInspection */ $this->parameters['__files']->saveFiles($saveStrategy); /** @var Media[] $mediaFiles */ @@ -838,7 +831,6 @@ public function replaceFile() } /** @var UploadFile[] $files */ - /** @noinspection PhpUndefinedMethodInspection */ $files = $this->parameters['__files']->getFiles(); foreach ($files as $file) { if ($file->getValidationErrorType()) { diff --git a/wcfsetup/install/files/lib/data/page/PageAction.class.php b/wcfsetup/install/files/lib/data/page/PageAction.class.php index 17198906595..f81220ba1be 100644 --- a/wcfsetup/install/files/lib/data/page/PageAction.class.php +++ b/wcfsetup/install/files/lib/data/page/PageAction.class.php @@ -85,7 +85,6 @@ public function create() if (!empty($this->parameters['content'])) { foreach ($this->parameters['content'] as $languageID => $content) { if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['content'] = $content['htmlInputProcessor']->getHtml(); } @@ -116,7 +115,6 @@ public function create() // save embedded objects if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['htmlInputProcessor']->setObjectID($pageContent->pageContentID); if (MessageEmbeddedObjectManager::getInstance()->registerObjects($content['htmlInputProcessor'])) { $pageContentEditor->update(['hasEmbeddedObjects' => 1]); @@ -175,7 +173,6 @@ public function update() foreach ($this->parameters['content'] as $languageID => $content) { if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['content'] = $content['htmlInputProcessor']->getHtml(); } @@ -232,7 +229,6 @@ public function update() // save embedded objects if (!empty($content['htmlInputProcessor'])) { - /** @noinspection PhpUndefinedMethodInspection */ $content['htmlInputProcessor']->setObjectID($pageContent->pageContentID); if ($pageContent->hasEmbeddedObjects != MessageEmbeddedObjectManager::getInstance()->registerObjects($content['htmlInputProcessor'])) { $pageContentEditor->update(['hasEmbeddedObjects' => $pageContent->hasEmbeddedObjects ? 0 : 1]); diff --git a/wcfsetup/install/files/lib/data/paid/subscription/user/PaidSubscriptionUserAction.class.php b/wcfsetup/install/files/lib/data/paid/subscription/user/PaidSubscriptionUserAction.class.php index 174bdabacf3..b30f6591380 100644 --- a/wcfsetup/install/files/lib/data/paid/subscription/user/PaidSubscriptionUserAction.class.php +++ b/wcfsetup/install/files/lib/data/paid/subscription/user/PaidSubscriptionUserAction.class.php @@ -54,7 +54,6 @@ public function create() $this->parameters['data']['endDate'] = 0; } else { $d = DateUtil::getDateTimeByTimestamp($this->parameters['data']['startDate']); - /** @noinspection PhpUndefinedMethodInspection */ $d->add($this->parameters['subscription']->getDateInterval()); $this->parameters['data']['endDate'] = $d->getTimestamp(); } diff --git a/wcfsetup/install/files/lib/data/template/Template.class.php b/wcfsetup/install/files/lib/data/template/Template.class.php index b44b470f9b9..20f7fd14a2b 100644 --- a/wcfsetup/install/files/lib/data/template/Template.class.php +++ b/wcfsetup/install/files/lib/data/template/Template.class.php @@ -30,8 +30,6 @@ class Template extends DatabaseObject */ protected static $systemCriticalTemplates = ['headIncludeJavaScript', 'shared_wysiwyg', 'wysiwygToolbar']; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * @inheritDoc */ diff --git a/wcfsetup/install/files/lib/data/user/activity/event/UserActivityEventAction.class.php b/wcfsetup/install/files/lib/data/user/activity/event/UserActivityEventAction.class.php index 620bf4f423c..97504c3966a 100644 --- a/wcfsetup/install/files/lib/data/user/activity/event/UserActivityEventAction.class.php +++ b/wcfsetup/install/files/lib/data/user/activity/event/UserActivityEventAction.class.php @@ -151,7 +151,6 @@ public function validateSwitchContext() {} */ public function switchContext() { - /** @noinspection PhpUndefinedFieldInspection */ $userAction = new UserAction([WCF::getUser()], 'update', [ 'options' => [ User::getUserOptionID('recentActivitiesFilterByFollowing') => WCF::getUser()->recentActivitiesFilterByFollowing ? 0 : 1, diff --git a/wcfsetup/install/files/lib/data/user/follow/UserFollowingList.class.php b/wcfsetup/install/files/lib/data/user/follow/UserFollowingList.class.php index 04e5741b58c..8313ca906d7 100644 --- a/wcfsetup/install/files/lib/data/user/follow/UserFollowingList.class.php +++ b/wcfsetup/install/files/lib/data/user/follow/UserFollowingList.class.php @@ -16,8 +16,6 @@ class UserFollowingList extends UserFollowerList */ public $useQualifiedShorthand = false; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * @inheritDoc */ diff --git a/wcfsetup/install/files/lib/form/UserSearchForm.class.php b/wcfsetup/install/files/lib/form/UserSearchForm.class.php index 4116d0c8df6..705d2603696 100644 --- a/wcfsetup/install/files/lib/form/UserSearchForm.class.php +++ b/wcfsetup/install/files/lib/form/UserSearchForm.class.php @@ -83,7 +83,6 @@ public function readFormParameters() */ protected function initOptionHandler() { - /** @noinspection PhpUndefinedMethodInspection */ $this->optionHandler->enableSearchMode(); $this->optionHandler->init(); } diff --git a/wcfsetup/install/files/lib/system/CLIWCF.class.php b/wcfsetup/install/files/lib/system/CLIWCF.class.php index ed9d2896997..c5fdee33b4f 100644 --- a/wcfsetup/install/files/lib/system/CLIWCF.class.php +++ b/wcfsetup/install/files/lib/system/CLIWCF.class.php @@ -45,8 +45,6 @@ class CLIWCF extends WCF */ protected static $argvParser; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * Calls all init functions of the WCF class. */ diff --git a/wcfsetup/install/files/lib/system/WCFACP.class.php b/wcfsetup/install/files/lib/system/WCFACP.class.php index a77ff33f294..782724d9ecd 100644 --- a/wcfsetup/install/files/lib/system/WCFACP.class.php +++ b/wcfsetup/install/files/lib/system/WCFACP.class.php @@ -32,8 +32,6 @@ class WCFACP extends WCF */ protected static string $rescueModePageURL; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * Calls all init functions of the WCF and the WCFACP class. */ diff --git a/wcfsetup/install/files/lib/system/WCFSetup.class.php b/wcfsetup/install/files/lib/system/WCFSetup.class.php index 63e61e25bac..97714399a5b 100644 --- a/wcfsetup/install/files/lib/system/WCFSetup.class.php +++ b/wcfsetup/install/files/lib/system/WCFSetup.class.php @@ -76,8 +76,6 @@ final class WCFSetup extends WCF */ protected static $developerMode = 0; - /** @noinspection PhpMissingParentConstructorInspection */ - /** * Calls all init functions of the WCFSetup class and starts the setup process. */ @@ -1060,7 +1058,6 @@ protected function installPackages(): ResponseInterface \rename($from, $to); - /** @noinspection PhpUndefinedVariableInspection */ $queue = PackageInstallationQueueEditor::create([ 'parentQueueID' => $queue->queueID, 'processNo' => $processNo, diff --git a/wcfsetup/install/files/lib/system/api/sebastian/diff/src/MemoryEfficientLongestCommonSubsequenceCalculator.php b/wcfsetup/install/files/lib/system/api/sebastian/diff/src/MemoryEfficientLongestCommonSubsequenceCalculator.php index b9846c37e78..5f4af01f21f 100644 --- a/wcfsetup/install/files/lib/system/api/sebastian/diff/src/MemoryEfficientLongestCommonSubsequenceCalculator.php +++ b/wcfsetup/install/files/lib/system/api/sebastian/diff/src/MemoryEfficientLongestCommonSubsequenceCalculator.php @@ -1,4 +1,6 @@ - $prev[$j + 1]) { diff --git a/wcfsetup/install/files/lib/system/box/RecentActivityListBoxController.class.php b/wcfsetup/install/files/lib/system/box/RecentActivityListBoxController.class.php index de288cf49d2..6a046357f49 100644 --- a/wcfsetup/install/files/lib/system/box/RecentActivityListBoxController.class.php +++ b/wcfsetup/install/files/lib/system/box/RecentActivityListBoxController.class.php @@ -102,7 +102,6 @@ protected function getObjectList() public function getTemplate() { if ($this->getBox()->position == 'contentTop' || $this->getBox()->position == 'contentBottom') { - /** @noinspection PhpUndefinedMethodInspection */ return WCF::getTPL()->render('wcf', 'boxRecentActivity', [ 'boxID' => $this->getBox()->boxID, 'canFilterByFollowedUsers' => $this->canFilterByFollowedUsers, @@ -167,7 +166,6 @@ protected function readObjects() parent::readObjects(); // removes orphaned and non-accessible events - /** @noinspection PhpParamsInspection */ UserActivityEventHandler::validateEvents($this->objectList); // remove unused items diff --git a/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php b/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php index 4908fc39c73..0188ab39f2d 100644 --- a/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php +++ b/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php @@ -33,7 +33,6 @@ public function rebuild(array $parameters) ACLHandler::getInstance()->getObjectTypeID($aclObjectType), \array_keys($categories) ); - /** @noinspection PhpUndefinedMethodInspection */ $options = $aclOptions['options']->getObjects(); foreach (['group', 'user'] as $type) { diff --git a/wcfsetup/install/files/lib/system/clipboard/ClipboardHandler.class.php b/wcfsetup/install/files/lib/system/clipboard/ClipboardHandler.class.php index 9645e73e481..2a129af4358 100644 --- a/wcfsetup/install/files/lib/system/clipboard/ClipboardHandler.class.php +++ b/wcfsetup/install/files/lib/system/clipboard/ClipboardHandler.class.php @@ -251,7 +251,6 @@ protected function loadMarkedItems($objectTypeID = null) } if (!isset($data[$objectType->objectType])) { - /** @noinspection PhpUndefinedFieldInspection */ $listClassName = $objectType->listclassname; if ($listClassName == '') { throw new SystemException("Missing list class for object type '" . $objectType->objectType . "'"); @@ -281,7 +280,6 @@ protected function loadMarkedItems($objectTypeID = null) // validate object ids against loaded items (check for zombie object ids) $indexName = $objectList->getDatabaseTableIndexName(); foreach ($this->markedItems[$objectType] as $object) { - /** @noinspection PhpVariableVariableInspection */ $index = \array_search($object->{$indexName}, $objectData['objectIDs']); unset($objectData['objectIDs'][$index]); } diff --git a/wcfsetup/install/files/lib/system/condition/AbstractMultiCategoryCondition.class.php b/wcfsetup/install/files/lib/system/condition/AbstractMultiCategoryCondition.class.php index c9baf8c36e0..a4f62a1fcc6 100644 --- a/wcfsetup/install/files/lib/system/condition/AbstractMultiCategoryCondition.class.php +++ b/wcfsetup/install/files/lib/system/condition/AbstractMultiCategoryCondition.class.php @@ -34,7 +34,6 @@ abstract class AbstractMultiCategoryCondition extends AbstractMultiSelectConditi */ protected function getFieldElement() { - /** @noinspection PhpUndefinedMethodInspection */ $categoryTree = (new $this->nodeTreeClassname($this->objectType))->getIterator(); $categoryCount = \iterator_count($categoryTree); diff --git a/wcfsetup/install/files/lib/system/condition/AbstractTimestampCondition.class.php b/wcfsetup/install/files/lib/system/condition/AbstractTimestampCondition.class.php index f39b374a686..71ef2e8e372 100644 --- a/wcfsetup/install/files/lib/system/condition/AbstractTimestampCondition.class.php +++ b/wcfsetup/install/files/lib/system/condition/AbstractTimestampCondition.class.php @@ -211,13 +211,11 @@ public function reset() */ public function setData(Condition $condition) { - /** @noinspection PhpUndefinedFieldInspection */ $endTime = $condition->endTime; if ($endTime) { $this->endTime = $endTime; } - /** @noinspection PhpUndefinedFieldInspection */ $startTime = $condition->startTime; if ($startTime) { $this->startTime = $startTime; diff --git a/wcfsetup/install/files/lib/system/condition/DaysOfWeekCondition.class.php b/wcfsetup/install/files/lib/system/condition/DaysOfWeekCondition.class.php index 626995b38d4..59f384f51cb 100644 --- a/wcfsetup/install/files/lib/system/condition/DaysOfWeekCondition.class.php +++ b/wcfsetup/install/files/lib/system/condition/DaysOfWeekCondition.class.php @@ -53,7 +53,6 @@ public function showContent(Condition $condition) $date = DateUtil::getDateTimeByTimestamp(TIME_NOW); $date->setTimezone(WCF::getUser()->getTimeZone()); - /** @noinspection PhpUndefinedFieldInspection */ return \in_array($date->format('w'), $condition->daysOfWeek); } } diff --git a/wcfsetup/install/files/lib/system/condition/TimeCondition.class.php b/wcfsetup/install/files/lib/system/condition/TimeCondition.class.php index 1bc2b34d79c..54ed66a895a 100644 --- a/wcfsetup/install/files/lib/system/condition/TimeCondition.class.php +++ b/wcfsetup/install/files/lib/system/condition/TimeCondition.class.php @@ -148,19 +148,16 @@ public function reset() */ public function setData(Condition $condition) { - /** @noinspection PhpUndefinedFieldInspection */ $endTime = $condition->endTime; if ($endTime) { $this->endTime = $endTime; } - /** @noinspection PhpUndefinedFieldInspection */ $startTime = $condition->startTime; if ($startTime) { $this->startTime = $startTime; } - /** @noinspection PhpUndefinedFieldInspection */ $timezone = $condition->timezone; if ($timezone) { $this->timezone = $timezone; @@ -217,13 +214,11 @@ public function validate() public function showContent(Condition $condition) { $timezone = WCF::getUser()->getTimeZone(); - /** @noinspection PhpUndefinedFieldInspection */ $conditionTimezone = $condition->timezone; if ($conditionTimezone) { $timezone = new \DateTimeZone($conditionTimezone); } - /** @noinspection PhpUndefinedFieldInspection */ $startTime = $condition->startTime; if ($startTime) { $dateTime = \DateTimeImmutable::createFromFormat('H:i', $startTime, $timezone); @@ -232,7 +227,6 @@ public function showContent(Condition $condition) } } - /** @noinspection PhpUndefinedFieldInspection */ $endTime = $condition->endTime; if ($endTime) { $dateTime = \DateTimeImmutable::createFromFormat('H:i', $endTime, $timezone); diff --git a/wcfsetup/install/files/lib/system/condition/UserGroupCondition.class.php b/wcfsetup/install/files/lib/system/condition/UserGroupCondition.class.php index 7663157fd77..f1a771ab99c 100644 --- a/wcfsetup/install/files/lib/system/condition/UserGroupCondition.class.php +++ b/wcfsetup/install/files/lib/system/condition/UserGroupCondition.class.php @@ -184,7 +184,6 @@ protected function getOptionElements($identifier) $returnValue = '