Skip to content

Filter participants using the table wcf1_conversation_to_user #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cyperghost merged 1 commit into from
Jul 9, 2025
Merged

Filter participants using the table wcf1_conversation_to_user #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 64 additions & 1 deletion files/lib/system/listView/user/ConversationListView.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function __construct(string $filter = '')

$this->addAvailableFilters([
new TextFilter('subject', 'wcf.global.title'),
new UserFilter('participants', 'wcf.conversation.participants'),
...$this->getParticipantFilter($filter),
$this->getLabelFilter(),
]);

Expand Down Expand Up @@ -87,6 +87,69 @@ public function getParameters(): array
return ['filter' => $this->filter];
}

/**
* @return AbstractFilter[]
*/
private function getParticipantFilter(string $filter): array
{
// Participants in draft conversations are not yet stored in the `wcf1_conversation_to_user` table,
// they are serialized in `draftData`.
if ($filter === 'draft') {
return [];
}

return [
new class(id: 'participants', languageItem: 'wcf.conversation.participants') extends UserFilter {
#[\Override]
public function applyFilter(DatabaseObjectList $list, string $value): void
{
// The condition is split into two branches in order to account for invisible participants.
// Invisible participants are only visible to the conversation starter and remain invisible
// until they write their first message.
//
// We need to protect these users from being exposed as participants by including them for
// any conversation that the current user has started. For all other conversations, users
// flagged with `isInvisible = 0` must be excluded.
//
// See https://github.com/WoltLab/com.woltlab.wcf.conversation/issues/131

$list->getConditionBuilder()->add(
"(
(
conversation.userID = ?
AND conversation.conversationID IN (
SELECT conversationID
FROM wcf1_conversation_to_user
WHERE participantID = ?
)
)
OR
(
conversation.userID <> ?
AND conversation.conversationID IN (
SELECT conversationID
FROM wcf1_conversation_to_user
WHERE participantID = ?
AND isInvisible = ?
)
)
)",
[
// Parameters for the first condition.
WCF::getUser()->userID,
$value,

// Parameters for the second condition.
WCF::getUser()->userID,
$value,
0,
]
);
}
},
];
}

private function getLabelFilter(): AbstractFilter
{
return new class extends AbstractFilter {
Expand Down