Skip to content

Commit ff7b514

Browse files
BurntimeXdtdesign
andauthored
Apply suggestions from code review
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
1 parent 68a195c commit ff7b514

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

docs/tutorial/series/part_1.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ The fourth level menu item `wcf.acp.menu.link.person.add` will only be shown as
198198

199199
### People List
200200

201-
To list the people in the ACP, we need the classes `PersonListPage` and `PersonGridView` and a `personList` template.
201+
To list the people in the ACP, we need the classes `PersonListPage`, `PersonGridView`, and a `personList` template.
202202

203203
#### `PersonListPage`
204204

@@ -226,7 +226,7 @@ To list the people in the ACP, we need the classes `PersonListPage` and `PersonG
226226
The following features are defined in the grid view:
227227

228228
1. The columns to be displayed and their order.
229-
1. Which columns can be sorted and what the default sorting is.
229+
1. Which columns can be sorted and what their default sorting is.
230230
1. What interaction options the user has with the displayed items.
231231

232232
#### `personList.tpl`

docs/tutorial/series/part_2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ The language item `wcf.person.birthday` used in the label is the only new one fo
119119

120120
## Adding Birthday Table Column in ACP
121121

122-
To add a birthday column to the person list page in the ACP, we need to listener to the `PersonGridViewInitialized` event and add the additional column:
122+
To add a birthday column to the person list page in the ACP, we need to listen to the `PersonGridViewInitialized` event and add the additional column:
123123

124124
{jinja{ codebox(
125125
title="files/lib/bootstrap/com.woltlab.wcf.people.birthday.php",

docs/tutorial/series/part_3.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ With this option, comments on individual people can be disabled.
149149
The `PersonPage` class is similar to the `PersonEditForm` in the ACP in that it reads the id of the requested person from the request data and validates the id in `readParameters()`.
150150
The rest of the code only handles fetching the list of comments on the requested person.
151151
In `readData()`, this list is fetched using a `CommentsView` if comments are enabled for the person.
152-
The `assignVariables()` method assigns this view as a template variables.
152+
The `assignVariables()` method assigns this view as a template variable.
153153

154154
### `person.tpl`
155155

0 commit comments

Comments
 (0)