Open
Conversation
There was a problem hiding this comment.
Pull request overview
Restores backward-compatible parsing of legacy tournament replay records by defaulting newer SessionTournamentInfo fields so older persisted data can still be loaded through shared Zod schemas.
Changes:
- Added Zod defaults for newer
SessionTournamentInfofields (pendingExtension,matchJoinTimeoutInMs,leftProfileId,rightProfileId) to support legacy records. - Added a backend regression test that parses a legacy tournament game record missing those fields and asserts defaulted values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/shared/src/tournaments.ts |
Adds Zod defaults to tolerate missing newer tournament session fields in old persisted records. |
packages/backend/src/persistence/gameHistoryRepository.test.ts |
Introduces a regression test ensuring legacy tournament replay records parse and receive expected defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Rename regression test to cover all defaulted legacy fields - Constrain matchJoinTimeoutInMs to non-negative durations - Drop void prefix on test() to match repo style
Contributor
Author
|
willfixhopefully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionTournamentInfofieldspendingExtension→false,matchJoinTimeoutInMs→null,leftProfileId/rightProfileId→null) so old records parse cleanly through bothzDatabaseGameandzFinishedGameRecord