Skip to content

feat: add custom properties for Ark UI Accordion & Collapsible#60

Open
thevipinmishra wants to merge 2 commits into
Wombosvideo:mainfrom
thevipinmishra:main
Open

feat: add custom properties for Ark UI Accordion & Collapsible#60
thevipinmishra wants to merge 2 commits into
Wombosvideo:mainfrom
thevipinmishra:main

Conversation

@thevipinmishra
Copy link
Copy Markdown

I'm building a shadcn/ui compatible fork with Ark UI and thought of adding the relevant properties to support accordion and collapsible content height animations.

Accordion - https://ark-ui.com/docs/components/accordion#animate-content-size

Collapsible - https://ark-ui.com/docs/components/collapsible#animating-the-content

@Wombosvideo
Copy link
Copy Markdown
Owner

Hey there! Sorry for the late response and thank you for your contribution. I can see you didn't update the docs. Can you do that too?

Also, as a warning, there might be changes in 2.0.0 because the list of CSS variables is getting longer and longer. But I still have to figure out how to best solve that problem without compromising first-hand support for component libraries.

@thevipinmishra
Copy link
Copy Markdown
Author

Hey @Wombosvideo, appreciate your time on this one.

I've updated the documentation for both the components.

Also, as a warning, there might be changes in 2.0.0 because the list of CSS variables is getting longer and longer. But I still have to figure out how to best solve that problem without compromising first-hand support for component libraries.

Yes, I saw the draft PR, I'll see if I can contribute to it as well. Thanks!

@Wombosvideo
Copy link
Copy Markdown
Owner

I'm really sorry for not getting back to you earlier, there's been a lot going on. I'll try to integrate Ark UI support but I have to fix the release pipeline first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants