Merge pull request #10 from WonderNetwork/feature/deserialize-nested-objects

Fix: deserializing nested objects

Author: mlebkowski

src/Http/Serializer/DeserializeParameterResolver.php

@@ -7,6 +7,8 @@
 use ReflectionFunctionAbstract;
 use ReflectionNamedType;
 use Slim\Exception\HttpBadRequestException;
+use Symfony\Component\Serializer\Encoder\CsvEncoder;
+use Symfony\Component\Serializer\Encoder\JsonEncoder;
 use Symfony\Component\Serializer\Exception\ExceptionInterface;
 use Symfony\Component\Serializer\Exception\MissingConstructorArgumentsException;
 use Symfony\Component\Serializer\Exception\NotNormalizableValueException;
@@ -50,10 +52,16 @@ public function getParameters(
                     PayloadSource::Get => $request->getQueryParams(),
                 };
 
+                $format = match ($attribute->source) {
+                    PayloadSource::Post => JsonEncoder::FORMAT,
+                    PayloadSource::Get => CsvEncoder::FORMAT,
+                };
+
                 try {
                     $resolvedParameters[$index] = $this->serializer->denormalize(
                         $data,
                         $parameterClass,
+                        format: $format,
                         context: $attribute->context,
                     );
                 } catch (NotNormalizableValueException $e) {

src/ServiceFactory/SlimServiceFactory.php

@@ -19,6 +19,8 @@
 use Slim\Middleware\ErrorMiddleware;
 use Slim\Psr7\Factory\ResponseFactory;
 use Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor;
+use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
+use Symfony\Component\PropertyInfo\PropertyInfoExtractor;
 use Symfony\Component\Serializer\Normalizer\ArrayDenormalizer;
 use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
@@ -38,7 +40,12 @@ public function __invoke(ServicesBuilder $builder): iterable {
         yield Serializer::class => static fn () => new Serializer([
             new ArrayDenormalizer(),
             new ObjectNormalizer(
-                propertyTypeExtractor: new PhpDocExtractor(),
+                propertyTypeExtractor: new PropertyInfoExtractor(
+                    typeExtractors: [
+                        new PhpDocExtractor(),
+                        new ReflectionExtractor(),
+                    ],
+                ),
             ),
         ]);
         yield DenormalizerInterface::class => get(Serializer::class);

tests/Http/Serializer/BooleansInput.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WonderNetwork\SlimKernel\Http\Serializer;
+
+final class BooleansInput {
+    public bool $true;
+    public bool $false;
+    public bool $one;
+    public bool $zero;
+}

tests/Http/Serializer/DeserializeParameterResolverTest.php

@@ -24,17 +24,37 @@ public function testDeserialize(): void {
                 ['name' => 'cats'],
                 ['name' => 'dogs'],
             ],
+            'tag' => [
+                'name' => 'alpha',
+            ],
         ];
         $get = [
             'page' => 3,
+            'lists' => ['alpha', 'bravo'],
+            'arrays' => ['charlie' => 'delta'],
+            'booleans' => [
+                'true' => true,
+                'false' => false,
+                'one' => 1,
+                'zero' => 0,
+            ],
         ];
 
         $request = (new ServerRequestFactory())
             ->createServerRequest('GET', '/?'.http_build_query($get))
             ->withParsedBody($post);
         $response = $app->handle($request);
+
+        $body = $response->getBody()->getContents();
+
+        self::assertSame(
+            200,
+            $response->getStatusCode(),
+            $body,
+        );
+
         $actual = json_decode(
-            $response->getBody()->getContents(),
+            $body,
             associative: true,
             depth: 12,
             flags: JSON_THROW_ON_ERROR,

tests/Http/Serializer/EchoController.php

@@ -12,10 +12,11 @@ public function __invoke(
         #[Payload(source: PayloadSource::Get)] SampleGetInput $get,
         ResponseInterface $response,
     ): ResponseInterface {
-        return $response->withBody(
-            (new StreamFactory())->createStream(
-                json_encode(compact('post', 'get'), JSON_THROW_ON_ERROR),
-            ),
-        );
+        $streamFactory = new StreamFactory();
+        $payload = compact('post', 'get');
+        $json = json_encode($payload, JSON_THROW_ON_ERROR);
+        $body = $streamFactory->createStream($json);
+
+        return $response->withBody($body);
     }
 }

tests/Http/Serializer/SampleGetInput.php

@@ -6,4 +6,13 @@
 final class SampleGetInput {
     public int $page = 1;
     public int $perPage = 100;
+    /**
+     * @var string[]
+     */
+    public array $lists;
+    /**
+     * @var array<string, string>
+     */
+    public array $arrays;
+    public BooleansInput $booleans;
 }

tests/Http/Serializer/SamplePostInput.php

@@ -8,4 +8,5 @@ final class SamplePostInput {
     public int $value;
     /** @var TagInput[] */
     public array $tags;
+    public TagInput $tag;
 }