Skip to content

Commit 12e1625

Browse files
authored
Merge pull request #33 from WordPress-Phoenix/feature/Textarea_fix
Fixing Textarea value display issue
2 parents 9f0b735 + fdf0df7 commit 12e1625

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- run:
1414
name: Install Testing Dependencies
1515
command: |
16-
composer require --dev --no-update "wp-coding-standards/wpcs" ; \
16+
composer require --dev --no-update "wp-coding-standards/wpcs:^0.14.1" ; \
1717
composer install --dev --no-autoloader ; \
1818
sudo ./vendor/bin/phpcs --config-set installed_paths $PWD/vendor/wp-coding-standards/wpcs ;
1919
- run: sudo ./vendor/bin/phpcs --config-set installed_paths $PWD/vendor/wp-coding-standards/wpcs

inc/class-page.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public function page_header() {
123123
<?php
124124
endif;
125125
echo esc_attr( $this->page_title );
126-
?>
126+
?>
127127
</h1>
128128
<input type="submit" class="button button-primary button-hero save-all" value="Save All" name="submit"/>
129129
</div>
@@ -164,7 +164,7 @@ public function page_content_sidebar() {
164164
<?php
165165
endif;
166166
echo esc_html( $section['label'] );
167-
?>
167+
?>
168168
<?php if ( count( $section['parts'] ) > 1 ) : ?>
169169
<small class="part-count">
170170
<?php echo esc_attr( count( $section['parts'] ) ); ?>

inc/parts/class-textarea.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ class Textarea extends Part {
4747
public function render() {
4848
$this->cols = ! empty( $this->cols ) ? $this->cols : 80;
4949
$this->rows = ! empty( $this->rows ) ? $this->rows : 10;
50+
// @codingStandardsIgnoreStart
5051
?><textarea title="<?php echo esc_attr( $this->id ); ?>"
51-
id="<?php echo esc_attr( $this->id ); ?>" name="<?php echo esc_attr( $this->id ); ?>"
52-
cols="<?php echo esc_attr( $this->cols ); ?>" rows="<?php echo esc_attr( $this->rows ); ?>">
53-
<?php
54-
echo esc_html( $this->saved );
55-
?>
56-
</textarea>
52+
id="<?php echo esc_attr( $this->id ); ?>" name="<?php echo esc_attr( $this->id ); ?>"
53+
cols="<?php echo esc_attr( $this->cols ); ?>" rows="<?php echo esc_attr( $this->rows ); ?>"><?php
54+
echo esc_html( $this->get_saved() );
55+
?></textarea>
5756
<?php
57+
// @codingStandardsIgnoreEnd
5858
}
5959

6060
}

wpop-init.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*
55
* @authors 🌵 WordPress Phoenix 🌵 / Seth Carstens, David Ryan
66
* @package wpop
7-
* @version 4.1.8
7+
* @version 4.1.9
88
* @license GPL-2.0+ - please retain comments that express original build of this file by the author.
99
*/
1010

0 commit comments

Comments
 (0)