Apply suggestions from code review

Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>

Author: rodrigoprimo

WordPress/Sniffs/Arrays/ArrayDeclarationSpacingSniff.php

@@ -39,7 +39,7 @@
  * @since 3.0.0  Removed various whitespace related checks and fixers in favor of the PHPCSExtra
  *               `NormalizedArrays.Arrays.ArrayBraceSpacing` sniff.
  * @since 3.4.0  The `allow_single_item_single_line_associative_arrays` property has been
- *               deprecated in favor of `allow_single_item_single_line_explicit_key_arrays`.
+ *               deprecated in favor of the new `allow_single_item_single_line_explicit_key_arrays` property.
  */
 final class ArrayDeclarationSpacingSniff extends Sniff {
 
@@ -130,9 +130,9 @@ protected function process_single_line_array( $stackPtr, $opener, $closer ) {
 		// the deprecated property's value.
 		$allow_single_item = $this->allow_single_item_single_line_explicit_key_arrays;
 		if ( true === $allow_single_item
-			&& true !== $this->allow_single_item_single_line_associative_arrays
+			&& false === $this->allow_single_item_single_line_associative_arrays
 		) {
-			$allow_single_item = $this->allow_single_item_single_line_associative_arrays;
+			$allow_single_item = false;
 		}
 
 		$array_items = PassedParameters::getParameters( $this->phpcsFile, $stackPtr );

WordPress/Tests/Arrays/ArrayDeclarationSpacingUnitTest.1.inc

@@ -88,3 +88,9 @@ $bad = array( 'key' => 'value' ); // Bad.
 $bad = array( 'key1' => 'value1', 'key2' => 'value2' ); // Bad.
 
 // phpcs:set WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_explicit_key_arrays true
+
+// phpcs:set WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_associative_arrays null
+
+$ok = array( 'key' => 'value' ); // OK, invalid value for deprecated property should be ignored.
+
+// phpcs:set WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_associative_arrays true

WordPress/Tests/Arrays/ArrayDeclarationSpacingUnitTest.1.inc.fixed

@@ -146,3 +146,9 @@ $bad = array(
 ); // Bad.
 
 // phpcs:set WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_explicit_key_arrays true
+
+// phpcs:set WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_associative_arrays null
+
+$ok = array( 'key' => 'value' ); // OK, invalid value for deprecated property should be ignored.
+
+// phpcs:set WordPress.Arrays.ArrayDeclarationSpacing allow_single_item_single_line_associative_arrays true