Change the placement of the namespaced name tests as suggested during PR review

Author: rodrigoprimo

WordPress/Tests/WP/DeprecatedParametersUnitTest.inc

@@ -37,6 +37,15 @@ wp_install( user_name: '', deprecated: '', user_email: '', blog_title: '', is_pu
 // Error: Parameter is passed with incorrect default, unconventional order.
 wp_install( is_public: '', user_name: '', user_email: '', deprecated: 'should be empty', blog_title: '' );
 
+/*
+ * Safeguard correct handling of all types of namespaced function calls.
+ */
+\add_option( '', '', [] ); // Bad.
+MyNamespace\get_blog_list( $foo, $bar, 'deprecated' ); // Ok.
+\MyNamespace\get_wp_title_rss( 'deprecated' ); // Ok.
+namespace\the_author( 'deprecated', 'deprecated' ); // The sniff should start flagging this once it can resolve relative namespaces.
+namespace\Sub\wp_title_rss( 'deprecated' ); // Ok.
+
 // All will give an ERROR. The functions are ordered alphabetically.
 
 _future_post_hook( 10, $post );
@@ -100,12 +109,3 @@ inject_ignored_hooked_blocks_metadata_attributes('', 'deprecated');
 // All will give an WARNING as they have been deprecated after WP 6.6.
 wp_render_elements_support_styles('deprecated');
 _wp_can_use_pcre_u('deprecated');
-
-/*
- * Safeguard correct handling of all types of namespaced function calls.
- */
-\add_option( '', '', [] ); // Bad.
-MyNamespace\get_blog_list( $foo, $bar, 'deprecated' ); // Ok.
-\MyNamespace\get_wp_title_rss( 'deprecated' ); // Ok.
-namespace\the_author( 'deprecated', 'deprecated' ); // The sniff should start flagging this once it can resolve relative namespaces.
-namespace\Sub\wp_title_rss( 'deprecated' ); // Ok.

WordPress/Tests/WP/DeprecatedParametersUnitTest.php

@@ -27,8 +27,8 @@ final class DeprecatedParametersUnitTest extends AbstractSniffUnitTest {
 	 * @return array<int, int> Key is the line number, value is the number of expected errors.
 	 */
 	public function getErrorList() {
-		$start_line = 42;
-		$end_line   = 98;
+		$start_line = 51;
+		$end_line   = 107;
 		$errors     = array_fill( $start_line, ( ( $end_line - $start_line ) + 1 ), 1 );
 
 		$errors[22] = 1;
@@ -38,12 +38,12 @@ public function getErrorList() {
 		// Named param.
 		$errors[38] = 1;
 
-		// Override number of errors.
-		$errors[50] = 2;
-		$errors[76] = 2;
-
 		// Fully qualified function call.
-		$errors[107] = 1;
+		$errors[43] = 1;
+
+		// Override number of errors.
+		$errors[59] = 2;
+		$errors[85] = 2;
 
 		return $errors;
 	}
@@ -55,8 +55,8 @@ public function getErrorList() {
 	 */
 	public function getWarningList() {
 		return array(
-			101 => 1,
-			102 => 1,
+			110 => 1,
+			111 => 1,
 		);
 	}
 }