WP/CronInterval: update test comments

Author: rodrigoprimo

WordPress/Tests/WP/CronIntervalUnitTest.inc

@@ -316,6 +316,7 @@ function first_class_weekly_schedule( $schedules ) {
 }
 add_filter( 'cron_schedules', 'first_class_weekly_schedule'(...)); // Ok: > 15 min.
 add_filter( 'cron_schedules', first_class_weekly_schedule(...)); // Ok: > 15 min.
+add_filter( 'cron_schedules', namespace\first_class_weekly_schedule(...)); // Ok: > 15 min.
 
 function first_class_six_min_schedule( $schedules ) {
 	$schedules['every_6_mins'] = array(
@@ -332,21 +333,24 @@ add_filter( 'cron_schedules', namespace\first_class_six_min_schedule(...)); // W
 /*
  * The tests below document the current behavior of the sniff, even though they are false negatives. The sniff treats
  * the first-class callable examples below as if referencing the global function first_class_six_min_schedule()
- * and not a namespaced function with the same name. Currently, those tests don't trigger a warning but instead
- * they should trigger the `ChangeDetected` warning. Fixing this incorrect behavior is not trivial.
+ * and not a namespaced function with the same name.
+ *
+ * Related to: https://github.com/WordPress/WordPress-Coding-Standards/issues/2644.
  */
-add_filter( 'cron_schedules', MyNamespace\first_class_weekly_schedule(...)); // Ok: > 15 min.
-add_filter( 'cron_schedules', \MyNamespace\first_class_weekly_schedule(...)); // Ok: > 15 min.
+add_filter( 'cron_schedules', MyNamespace\first_class_weekly_schedule(...)); // False negative - Ok: > 15 min, but should be marked `ChangeDetected`.
+add_filter( 'cron_schedules', \MyNamespace\first_class_weekly_schedule(...)); // False negative - Ok: > 15 min, but should be marked `ChangeDetected`.
+add_filter( 'cron_schedules', namespace\Sub\first_class_weekly_schedule(...)); // False negative - Ok: > 15 min, but should be marked `ChangeDetected`.
 
 /*
  * The tests below document the current behavior of the sniff, even though they are false positives. The sniff treats
  * the first-class callable examples below as if referencing the global function first_class_six_min_schedule()
- * and not a namespaced function with the same name. Currently, those tests trigger the `CronSchedulesInterval` warning
- * but instead they should trigger the `ChangeDetected` warning. Fixing this incorrect behavior is not trivial.
+ * and not a namespaced function with the same name. Fixing this incorrect behavior is not trivial.
+ *
+ * Related to: https://github.com/WordPress/WordPress-Coding-Standards/issues/2644.
  */
-add_filter( 'cron_schedules', MyNamespace\first_class_six_min_schedule(...)); // Warning: 6 min.
-add_filter( 'cron_schedules', \MyNamespace\first_class_six_min_schedule(...)); // Warning: 6 min.
-add_filter( 'cron_schedules', namespace\Sub\first_class_six_min_schedule(...)); // Warning: 6 min.
+add_filter( 'cron_schedules', MyNamespace\first_class_six_min_schedule(...)); // False positive - `CronSchedulesInterval` warning (6 min), but should be `ChangeDetected`.
+add_filter( 'cron_schedules', \MyNamespace\first_class_six_min_schedule(...)); // False positive - `CronSchedulesInterval` warning (6 min), but should be `ChangeDetected`.
+add_filter( 'cron_schedules', namespace\Sub\first_class_six_min_schedule(...)); // False positive - `CronSchedulesInterval` warning (6 min), but should be `ChangeDetected`.
 
 /*
  * Safeguard correct handling of all types of namespaced function calls (except FQN global function call which is

WordPress/Tests/WP/CronIntervalUnitTest.php

@@ -65,13 +65,13 @@ public function getWarningList() {
 			286 => 1,
 			288 => 1,
 			290 => 1,
-			327 => 1,
 			328 => 1,
 			329 => 1,
 			330 => 1,
-			347 => 1,
-			348 => 1,
-			349 => 1,
+			331 => 1,
+			351 => 1,
+			352 => 1,
+			353 => 1,
 		);
 	}
 }