NamingConventions/PrefixAllGlobals: address PR feedback

Author: rodrigoprimo

WordPress/Tests/NamingConventions/PrefixAllGlobalsUnitTest.3.inc

@@ -21,7 +21,8 @@ $acronym_test = new class extends \phpunit_framework_testcase {
 	}
 };
 
-class Some_Test extends WP_Font_Face_UnitTestCase {
+// Test namespace resolution when the sniff checks the extending class.
+class Extends_Namespaced_Class_Not_WP_Test extends WP_Font_Face_UnitTestCase {
 
     public function testPass() {
         do_action( 'some-action', $something );
@@ -31,21 +32,21 @@ class Some_Test extends WP_Font_Face_UnitTestCase {
 /*
  * Safeguard correct handling of namespaced extending classes.
  */
-class Some_Test extends MyNamespace\WP_UnitTestCase_Base {
+class Extends_Partially_Qualified_Not_WP_Test extends MyNamespace\WP_UnitTestCase_Base {
 
     public function testPass() {
         do_action( 'some-action', $something );
     }
 }
 
-class Some_Test extends \MyNamespace\WP_Ajax_UnitTestCase {
+class Extends_Fully_Qualified_Not_WP_Test extends \MyNamespace\WP_Ajax_UnitTestCase {
 
     public function testPass() {
         do_action( 'some-action', $something );
     }
 }
 
-class Some_Test extends namespace\WP_Canonical_UnitTestCase {
+class Extends_Relative_Namespace_Not_WP_Test extends namespace\WP_Canonical_UnitTestCase {
 
     public function testPass() {
         do_action( 'some-action', $something );

WordPress/Tests/NamingConventions/PrefixAllGlobalsUnitTest.php

@@ -100,19 +100,18 @@ public function getErrorList( $testFile = 'PrefixAllGlobalsUnitTest.1.inc' ) {
 					693 => 1,
 				);
 
-			case 'PrefixAllGlobalsUnitTest.4.inc':
+			case 'PrefixAllGlobalsUnitTest.3.inc':
 				return array(
-					1  => 1, // 1 x error for blocked prefix passed.
-					18 => 1,
+					28 => 1,
+					38 => 1,
+					45 => 1,
+					52 => 1,
 				);
 
-			case 'PrefixAllGlobalsUnitTest.3.inc':
-				// Test class - non-prefixed constant is fine.
+			case 'PrefixAllGlobalsUnitTest.4.inc':
 				return array(
-					27 => 1,
-					37 => 1,
-					44 => 1,
-					51 => 1,
+					1  => 1, // 1 x error for blocked prefix passed.
+					18 => 1,
 				);
 
 			case 'PrefixAllGlobalsUnitTest.2.inc':