Skip to content

Commit 781bb22

Browse files
committed
GH Actions: remove build with special set of extensions
There was a special build included which is supposed disable Mbstring and record code coverage, but the `extensions` key was missing from the `setup-php` action runner, so Mbstring was never disabled.... Another thing to know about this build is that Mbstring is a required extension for PHPUnit, but it is only really needed when PHPUnit is run with the `--testdox` CLI flag. In later PHPUnit versions, this requirement is enforced across the board (Composer + PHAR), but that's not yet the case for the PHPUnit 8 PHAR file. However, as we run the tests via a Composer install, that install will still fail on the PHPUnit `mbstring` requirement. All in all, this build adds nothing and can be removed.
1 parent e43f301 commit 781bb22

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

.github/workflows/unit-tests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ jobs:
3232
coverage: [false]
3333

3434
include:
35-
- php: '7.2'
36-
dependencies: 'stable'
37-
extensions: ':mbstring' # = Disable Mbstring.
38-
coverage: true # Make sure coverage is recorded for this too.
39-
4035
# Run code coverage builds against high/low PHP and high/low PHPCS.
4136
- php: '7.2'
4237
dependencies: 'stable'

0 commit comments

Comments
 (0)