AbstractFunctionParameterSniff: fix handling of unfinished function calls

Before this commit, the `AbstractFunctionParameterSniff` class would incorrectly treat an unfinished function call (missing closing parenthesis) as a function call without parameters. This behavior is now changed and the class will bail early when the closing parenthesis is missing and assume it is a syntax error or live coding.

Author: rodrigoprimo

WordPress/AbstractFunctionParameterSniff.php

@@ -99,11 +99,16 @@ public function is_targetted_token( $stackPtr ) {
 			return false;
 		}
 
+		if ( isset( $this->tokens[ $next ]['parenthesis_closer'] ) === false ) {
+			// Syntax error or live coding: missing closing parenthesis.
+			return false;
+		}
+
 		// First class callable.
 		$firstNonEmpty = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $next + 1 ), null, true );
-		if ( false !== $firstNonEmpty && \T_ELLIPSIS === $this->tokens[ $firstNonEmpty ]['code'] ) {
+		if ( \T_ELLIPSIS === $this->tokens[ $firstNonEmpty ]['code'] ) {
 			$secondNonEmpty = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $firstNonEmpty + 1 ), null, true );
-			if ( false === $secondNonEmpty || \T_CLOSE_PARENTHESIS === $this->tokens[ $secondNonEmpty ]['code'] ) {
+			if ( \T_CLOSE_PARENTHESIS === $this->tokens[ $secondNonEmpty ]['code'] ) {
 				return false;
 			}
 		}

WordPress/Tests/Utils/I18nTextDomainFixerUnitTest.7.inc

@@ -6,11 +6,10 @@
  * Intentional parse error (nothing after opening parenthesis).
  * This should be the only test in this file.
  *
- * Test to document that `AbstractFunctionParameterSniff::is_targetted_token()` returns true for a
- * function call even when there is nothing after the opening parenthesis. This test is added here
- * as there are no dedicated tests for the WPCS abstract classes. The WPCS abstract classes will be
- * replaced with PHPCSUtils similar classes in the future, so it is not worth creating dedicated
- * tests at this point.
+ * Test to document that `AbstractFunctionParameterSniff::is_targetted_token()` ignores unfinished
+ * function calls. This test is added here as there are no dedicated tests for the WPCS abstract
+ * classes. The WPCS abstract classes will be replaced with PHPCSUtils similar classes in the
+ * future, so it is not worth creating dedicated tests at this point.
  */
 
 __(

WordPress/Tests/Utils/I18nTextDomainFixerUnitTest.8.inc

@@ -195,11 +195,6 @@ public function getWarningList( $testFile = '' ) {
 					201 => 1,
 				);
 
-			case 'I18nTextDomainFixerUnitTest.7.inc':
-				return array(
-					16 => 1,
-				);
-
 			default:
 				return array();
 		}