Conversation
... to benefit from new functionality. This also automatically raises the minimum PHPCS version to `3.13.0` for PHP 8.2 DNF type support and tokenizer support for PHP 8.4 `final` properties and asymmetric visibility. Includes syncing the PHPCSExtra version to a version which also has a minimum PHPCSUtils version of 1.1.0. Ref: * https://github.com/PHPCSStandards/PHPCSUtils/releases/tag/1.1.0 * https://github.com/PHPCSStandards/PHPCSExtra/releases/tag/1.4.0
This was referenced Jun 14, 2025
GaryJones
approved these changes
Jun 15, 2025
dingo-d
approved these changes
Jun 16, 2025
dingo-d
deleted the
feature/composer-bump-phpcsutils-and-fix-test-failure
branch
Member
Author
|
@dingo-d Can I please remind you NOT to squash merge PRs with atomic commits ? |
Member
|
Ok, but didn't we said that all the PRs should be squash merged?! I'm a bit confused because from what I recall, we mentioned that all PRs should be squash merged in order to keep things atomic. I'll just refrain from merging in the future... |
Member
Author
No, I can't recall anything of the kind. "Dirty" PRs, yes, those should be squash merged, but clean PRs only containing atomic commits should retain those atomic commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just to unblock WPCS/fix the failing test run.
Fixing the failure test run without these version bumps would mean having to polyfill support for PHP 8.4 properties in interfaces, which is not something we should want to do (that's why we use PHPCSUtils, which does the polyfill for PHPCS 3.x as PHPCS natively will only start supporting this in PHPCS 4.0).
This PR does NOT:
Composer: raise the minimum supported PHPCSUtils version to 1.1.0
... to benefit from new functionality.
This also automatically raises the minimum PHPCS version to
3.13.0for PHP 8.2 DNF type support and tokenizer support for PHP 8.4finalproperties and asymmetric visibility.Includes syncing the PHPCSExtra version to a version which also has a minimum PHPCSUtils version of 1.1.0.
Ref:
NamingConventions/ValidVariableName: allow for PHP 8.4 properties in interfaces