Add XML documentation for OperatorSpacingSniff#2543
Closed
AnuragGaonkar wants to merge 1 commit into
Closed
Conversation
dingo-d
requested changes
Jul 17, 2025
Member
dingo-d
left a comment
There was a problem hiding this comment.
As mentioned in the comment, a lot of these aren't fixes.
I think this should be closed.
Please, check the contributing guide if you want to make contributions.
| <![CDATA[ | ||
| if ( $a<em> === </em>$b<em> && </em>$b<em> === </em>$c ) {} | ||
| if (<em> ! </em>$var ) {} | ||
| if ( $a === $b && $b === $c ) {} |
Member
There was a problem hiding this comment.
You shouldn't remove emphasis on errors. They serve a purpose (when you use HTML generator type you will see these bolded).
A lot of these fixes aren't valid...
Member
|
I agree with @dingo-d. There is nothing here which can be seen as an improvement. |
Member
|
Oh and it most definitely doesn't fix the linked issue. This just feels like AI slop, which is really not welcome here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds XML documentation for the
OperatorSpacingSniffunderWordPress/Sniffs/WhiteSpace/.Fixes: #2462