AbstractFunctionParameter sniffs: add tests for namespaced names#2633
Merged
jrfnl merged 15 commits intoWordPress:developfrom Apr 23, 2026
Merged
Conversation
Contributor
Author
|
Moved to draft pending the review of #2620 |
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
fbcdd23 to
1b63aec
Compare
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
1b63aec to
6040916
Compare
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
2 times, most recently
from
2db68b0 to
d476988
Compare
Contributor
Author
|
@jrfnl, since another PR was reviewed earlier today, I'm marking this one as ready for review now. |
jrfnl
reviewed
Mar 19, 2026
jrfnl
approved these changes
Mar 19, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
@rodrigoprimo Thanks for all your work on this and your patience waiting for the review.
All good from me!
Contributor
Author
|
@GaryJones and @dingo-d, would either of you be available to review this PR? It already has one approval. Thanks. |
GaryJones
approved these changes
Apr 23, 2026
Doing this to allow for additional testcase files.
I'm adding three different tests for fully qualified global function calls to cover all the global functions that are referenced directly in the `I18nSniff::process_matched_token()` method.
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
0da6a56 to
eac44b4
Compare
Contributor
Author
|
As discussed in a chat, I squashed the commit applying changes discussed during the PR review into the original commit that adds tests for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced function calls (partially qualified, fully qualified, and namespace-relative using the 'namespace' keyword) as well as fully qualified global function calls to the sniffs that extend the
AbstractFunctionParameterSniffclass when necessary. Some test files already contained part or all of the required tests.Tests for
WordPress.WP.EnqueuedResourceParametersare not included in this PR as they would conflict with #2630. I will add tests for this sniff in a separate PR once #2630 is merged.In some cases, it was necessary to move syntax error tests to a separate file before adding the new tests.
Suggested changelog entry
N/A