Security/ValidatedSanitizedInput: improve InputNotValidated error message#2642
Merged
dingo-d merged 1 commit intoNov 7, 2025
Conversation
…essage The error message for `InputNotValidated` previously listed specific methods (isset() and empty()), but the list was incomplete. Rather than expanding it, this commit adopts a more generic message that won't require updates when new validation methods are added. Fixes 2641 Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
dingo-d
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error message for
InputNotValidatedpreviously listed specific methods (isset() and empty()), but the list was incomplete. Rather than expanding it, this PR adopts a more generic message that won't require updates when new validation methods are added.@jrfnl, I made a small modification to the phrase that you suggested by adding "that" after "check". This way the sentences reads a bit better to me, but let me know if you disagree.
Suggested changelog entry
Changed:
WordPress.Security.ValidatedSanitizedInput: theInputNotValidatederror message is now more generic.Related issues/external references
Discussed in #2641