WP/CapitalPDangit: add tests for namespaced names#2673
Merged
dingo-d merged 1 commit intoDec 17, 2025
Merged
Conversation
jrfnl
approved these changes
Dec 16, 2025
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks for this PR @rodrigoprimo ! LGTM.
N.B.: I've verified that the other place where namespaced names could be problematic for PHPCS 4.0 (namespace declarations) is already sufficiently covered by tests.
dingo-d
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced function calls (partially qualified, fully qualified, and namespace-relative using the
namespacekeyword) to theWordPress.WP.CapitalPDangitsniff. The tests focus on calls to thedefine()function and namespaced variants that share the same name.Suggested changelog entry
N/A