From 1e334662bf22a983875a6c2e822d99e73d184a8b Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Thu, 6 Nov 2025 10:39:29 -0300 Subject: [PATCH] WP/CapitalPDangit: add tests for namespaced names --- WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc | 9 +++++++++ WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed | 9 +++++++++ WordPress/Tests/WP/CapitalPDangitUnitTest.php | 4 ++++ 3 files changed, 22 insertions(+) diff --git a/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc b/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc index 391148fb56..fd95c66be2 100644 --- a/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc +++ b/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc @@ -244,3 +244,12 @@ class TypeClassConstants { // Ensures no false positives on incorrect casing in a class constant type name. public const (\Fully\Qualified\MyClass&wordPRESS)|string ANOTHER_WORDPRESS = 'wordpress'; } + +/* + * Safeguard correct handling of all types of namespaced calls to the define() function. + */ +\DEFINE( 'WORDPRESS_SOMETHING', 'wordpress' ); // OK. +MyNamespace\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad. +\MyNamespace\Define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad. +namespace\Sub\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad. +namespace\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // The sniff should stop flagging this once it can resolve relative namespaces. diff --git a/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed b/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed index 5630f0d415..d43a7af60b 100644 --- a/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed +++ b/WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed @@ -244,3 +244,12 @@ class TypeClassConstants { // Ensures no false positives on incorrect casing in a class constant type name. public const (\Fully\Qualified\MyClass&wordPRESS)|string ANOTHER_WORDPRESS = 'wordpress'; } + +/* + * Safeguard correct handling of all types of namespaced calls to the define() function. + */ +\DEFINE( 'WORDPRESS_SOMETHING', 'wordpress' ); // OK. +MyNamespace\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad. +\MyNamespace\Define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad. +namespace\Sub\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad. +namespace\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // The sniff should stop flagging this once it can resolve relative namespaces. diff --git a/WordPress/Tests/WP/CapitalPDangitUnitTest.php b/WordPress/Tests/WP/CapitalPDangitUnitTest.php index ea1cfcf65e..ff545fcc65 100644 --- a/WordPress/Tests/WP/CapitalPDangitUnitTest.php +++ b/WordPress/Tests/WP/CapitalPDangitUnitTest.php @@ -69,6 +69,10 @@ public function getWarningList( $testFile = '' ) { 204 => 1, 205 => 1, 224 => 1, + 252 => 1, + 253 => 1, + 254 => 1, + 255 => 1, ); case 'CapitalPDangitUnitTest.2.inc':