Skip to content

WP/CapitalPDangit: add tests for namespaced names #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingo-d merged 1 commit into from
Dec 17, 2025
Merged

WP/CapitalPDangit: add tests for namespaced names #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,3 +244,12 @@ class TypeClassConstants {
// Ensures no false positives on incorrect casing in a class constant type name.
public const (\Fully\Qualified\MyClass&wordPRESS)|string ANOTHER_WORDPRESS = 'wordpress';
}

/*
* Safeguard correct handling of all types of namespaced calls to the define() function.
*/
\DEFINE( 'WORDPRESS_SOMETHING', 'wordpress' ); // OK.
MyNamespace\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad.
\MyNamespace\Define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad.
namespace\Sub\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad.
namespace\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // The sniff should stop flagging this once it can resolve relative namespaces.
9 changes: 9 additions & 0 deletions WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,3 +244,12 @@ class TypeClassConstants {
// Ensures no false positives on incorrect casing in a class constant type name.
public const (\Fully\Qualified\MyClass&wordPRESS)|string ANOTHER_WORDPRESS = 'wordpress';
}

/*
* Safeguard correct handling of all types of namespaced calls to the define() function.
*/
\DEFINE( 'WORDPRESS_SOMETHING', 'wordpress' ); // OK.
MyNamespace\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad.
\MyNamespace\Define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad.
namespace\Sub\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad.
namespace\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // The sniff should stop flagging this once it can resolve relative namespaces.
4 changes: 4 additions & 0 deletions WordPress/Tests/WP/CapitalPDangitUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ public function getWarningList( $testFile = '' ) {
204 => 1,
205 => 1,
224 => 1,
252 => 1,
253 => 1,
254 => 1,
255 => 1,
);

case 'CapitalPDangitUnitTest.2.inc':
Expand Down
Loading