Skip to content

CodeAnalysis/AssignmentInTernaryCondition: add XML documentation #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 1 commit into from
Feb 2, 2026
Merged

CodeAnalysis/AssignmentInTernaryCondition: add XML documentation #2678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?xml version="1.0"?>
<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
title="Assignment In Ternary Condition"
>
<standard>
<![CDATA[
Variables should not be assigned in the condition of a ternary expression. This is likely a mistake, as more often than not, a comparison was intended.

Side-note: This sniff can only detect assignments in ternary conditions when parentheses are used around either the ternary expression or its condition.
]]>
</standard>
<code_comparison>
<code title="Valid: Comparison operator used in ternary condition.">
<![CDATA[
echo ( $a <em>===</em> 'a' ) ? 'b' : 'c';
]]>
</code>
<code title="Invalid: Assignment in ternary condition.">
<![CDATA[
echo ( $a <em>=</em> 'a' ) ? 'b' : 'c';
]]>
</code>
</code_comparison>
</documentation>
Loading