PHP/NoSilencedErrors: remove tolerance for parse_url()#2701
Conversation
The `parse_url()` function was in the list of functions allowed to use error silencing due to it throwing an `E_WARNING` in certain circumstances in PHP < 5.3.3. I believe by now, we should no longer need to take PHP < 5.3.3 into account, so this exception should no longer be permitted.
parse_url()parse_url()
rodrigoprimo
left a comment
There was a problem hiding this comment.
LGTM! For reference, the PHP bug report confirming the E_WARNING was removed in PHP 5.3.3: https://bugs.php.net/bug.php?id=50563. And here is a 3v4l.org snippet showing the warning on PHP < 5.3.3, and no warning on any currently supported PHP version: https://3v4l.org/04lvl
Indeed. It used to also be in the docs, but references to PHP 5 were removed from the docs a couple of years ago. |
Description
The
parse_url()function was in the list of functions allowed to use error silencing due to it throwing anE_WARNINGin certain circumstances in PHP < 5.3.3.I believe by now, we should no longer need to take PHP < 5.3.3 into account, so this exception should no longer be permitted.
Suggested changelog entry
WordPress.PHP.NoSilencedErrors: error silencing is no longer accepted for theparse_url()function.