Security/ValidatedSanitizedInput: add tests for namespaced names#2709
Merged
GaryJones merged 1 commit intoApr 23, 2026
Merged
Conversation
rodrigoprimo
force-pushed
the
validated-sanitized-input-tests
branch
from
5224ff2 to
3f3bce0
Compare
rodrigoprimo
force-pushed
the
validated-sanitized-input-tests
branch
from
3f3bce0 to
7022365
Compare
jrfnl
reviewed
Mar 20, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks for working on this @rodrigoprimo !
jrfnl
approved these changes
Mar 20, 2026
Contributor
Author
|
@GaryJones and @dingo-d, would either of you be available to review this PR? It already has one approval. Thanks. |
GaryJones
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced function calls (partially qualified, fully qualified, and namespace-relative using the namespace keyword) as well as fully qualified global function calls to the
WordPress.Security.ValidatedSanitizedInputsniff.Suggested changelog entry
N/A