ContextHelper::is_in_type_test(): add tests#2721
Merged
Conversation
rodrigoprimo
force-pushed
the
is-in-type-test-tests
branch
from
416ae66 to
39c6af7
Compare
GaryJones
approved these changes
Apr 23, 2026
Member
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
Approved, with one suggestion.
rodrigoprimo
force-pushed
the
is-in-type-test-tests
branch
from
fe631e9 to
33999b2
Compare
Collaborator
Author
|
I added a new commit with a negative bare variable test as suggested in #2725 (review) for consistency. |
jrfnl
force-pushed
the
is-in-type-test-tests
branch
from
33999b2 to
5447a46
Compare
Member
|
I've rebased this PR without changes to get passed the imaginary merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for supporting PHPCS 4.0, this PR adds unit tests for the
ContextHelper::is_in_type_test()method.Suggested changelog entry
N/A