Security/EscapeOutput: make basename( __FILE__ ) pattern matching case-insensitive#2729
Open
rodrigoprimo wants to merge 1 commit intodevelopfrom
Open
Security/EscapeOutput: make basename( __FILE__ ) pattern matching case-insensitive#2729rodrigoprimo wants to merge 1 commit intodevelopfrom
rodrigoprimo wants to merge 1 commit intodevelopfrom
Conversation
…e-insensitive The sniff has special handling for `_deprecated_file()` calls where the first parameter follows the `basename( __FILE__ )` pattern. The regex pattern was case-sensitive, which meant it would only match lowercase `basename()` and uppercase `__FILE__`. This is incorrect because both function names and magic constants (https://3v4l.org/8nAEV and https://www.php.net/manual/en/language.constants.magic.php) in PHP are case-insensitive. This commit fixes the regex pattern to be case-insensitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
WordPress.Security.EscapeOutputsniffhas special handling for_deprecated_file()calls where the first parameter follows thebasename( __FILE__ )pattern.The regex pattern was case-sensitive, which meant it would only match lowercase
basename()and uppercase__FILE__. This is incorrect because both function names and magic constants (https://3v4l.org/8nAEV and https://www.php.net/manual/en/language.constants.magic.php) in PHP are case-insensitive.This PR fixes the regex pattern to be case-insensitive.
Suggested changelog entry
WordPress.Security.EscapeOutput: false negative for_deprecated_file()calls when thebasename( __FILE__ )pattern used non-standard casing forbasename()and/or__FILE__.