WP/CronInterval: make callback function name lookup case-insensitive#2730
Open
rodrigoprimo wants to merge 2 commits into
Open
WP/CronInterval: make callback function name lookup case-insensitive#2730rodrigoprimo wants to merge 2 commits into
rodrigoprimo wants to merge 2 commits into
Conversation
The sniff was incorrectly treating callback function names as case-sensitive when trying to locate the callback function definition. This led to false positives when the callback reference case did not match the function declaration case. The fix ensures callback names are compared case-insensitively using `strcasecmp()` when searching for function declarations in the code.
jrfnl
reviewed
Jun 26, 2026
jrfnl
left a comment
jrfnl
left a comment
Member
There was a problem hiding this comment.
@rodrigoprimo Thanks for this PR. Looks good to me. Just one tiny nitpick.
Comment on lines
167
to
169
| add_filter( 'cron_schedules', array( $this, 'ADD_WEEKLY_SCHEDULE' ) ); // Ok: > 15 min. | ||
| \add_filter( 'cron_schedules', array( $this, 'add_eight_minute_schedule' ) ); // Warning: 8 min. | ||
| ADD_FILTER( 'cron_schedules', array( $this, 'add_hundred_minute_schedule' ) ); // Warning: time undetermined. |
Member
There was a problem hiding this comment.
May I suggest using the "Warning: time undetermined" case for the "all caps" test instead ? That way all three possible situations (OK, warning time, warning undetermined) all have a test with a different cased callback.
Contributor
Author
There was a problem hiding this comment.
Thanks for your review, Juliette! I applied your suggestion in a new commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
WordPress.WP.CronIntervalsniff was incorrectly treating callback function names as case-sensitive when trying to locate the callback function definition. This led to false positives when the callback reference case did not match the function declaration case.The fix ensures callback names are compared case-insensitively using
strcasecmp()when searching for function declarations in the code.Suggested changelog entry
WordPress.WP.CronInterval: false positive when the callback function reference used different casing than the function declaration.