Experiment: Content types reuse createStatusAction (#78102)

ntsekouras · tyxla · web-flow · commit 73662749ec2f · 2026-05-08T18:25:49.000+03:00
Co-authored-by: ntsekouras &lt;ntsekouras@git.wordpress.org&gt;
Co-authored-by: tyxla &lt;tyxla@git.wordpress.org&gt;
diff --git a/packages/content-types/src/post-types/actions/activate.ts b/packages/content-types/src/post-types/actions/activate.ts
@@ -6,11 +6,14 @@ import { __, _n, sprintf } from '@wordpress/i18n';
 /**
  * Internal dependencies
  */
-import { createStatusAction } from './utils';
+import { createStatusAction } from '../../utils/actions';
+import { POST_TYPE_ENTITY } from '../../constants';
+import type { PostTypeFormData } from '../types';
 
-const activateAction = createStatusAction( {
+const activateAction = createStatusAction< PostTypeFormData >( {
 	id: 'activate',
 	label: __( 'Activate' ),
+	entity: POST_TYPE_ENTITY,
 	targetStatus: 'publish',
 	messages: {
 		successSingle: __( 'Post type activated.' ),
diff --git a/packages/content-types/src/post-types/actions/deactivate.ts b/packages/content-types/src/post-types/actions/deactivate.ts
@@ -6,11 +6,14 @@ import { __, _n, sprintf } from '@wordpress/i18n';
 /**
  * Internal dependencies
  */
-import { createStatusAction } from './utils';
+import { createStatusAction } from '../../utils/actions';
+import { POST_TYPE_ENTITY } from '../../constants';
+import type { PostTypeFormData } from '../types';
 
-const deactivateAction = createStatusAction( {
+const deactivateAction = createStatusAction< PostTypeFormData >( {
 	id: 'deactivate',
 	label: __( 'Deactivate' ),
+	entity: POST_TYPE_ENTITY,
 	targetStatus: 'draft',
 	messages: {
 		successSingle: __( 'Post type deactivated.' ),
diff --git a/packages/content-types/src/post-types/actions/delete.tsx b/packages/content-types/src/post-types/actions/delete.tsx
@@ -14,7 +14,8 @@ import { Stack, Text } from '@wordpress/ui';
 /**
  * Internal dependencies
  */
-import type { CoreDataError, PostTypeFormData } from '../types';
+import type { PostTypeFormData } from '../types';
+import type { CoreDataError } from '../../types';
 import { POST_TYPE_ENTITY } from '../../constants';
 
 function DeletePostTypeModal( {
diff --git a/packages/content-types/src/post-types/actions/duplicate.tsx b/packages/content-types/src/post-types/actions/duplicate.tsx
@@ -23,7 +23,8 @@ import { Stack } from '@wordpress/ui';
 import { useSlugField } from '../fields/general';
 import { pluralLabelField, singularLabelField } from '../../utils/fields';
 import { serializeForSave } from '../utils';
-import type { CoreDataError, PostTypeFormData } from '../types';
+import type { PostTypeFormData } from '../types';
+import type { CoreDataError } from '../../types';
 import { POST_TYPE_ENTITY } from '../../constants';
 
 const SLUG_MAX_LENGTH = 20;
diff --git a/packages/content-types/src/post-types/actions/utils.ts b/packages/content-types/src/post-types/actions/utils.ts
diff --git a/packages/content-types/src/post-types/types.ts b/packages/content-types/src/post-types/types.ts
@@ -86,5 +86,3 @@ export interface PostTypeFormData extends ContentType {
 		has_archive: boolean;
 	};
 }
-
-export type CoreDataError = { message?: string; code?: string };
diff --git a/packages/content-types/src/taxonomies/actions/activate.ts b/packages/content-types/src/taxonomies/actions/activate.ts
@@ -6,11 +6,14 @@ import { __, _n, sprintf } from '@wordpress/i18n';
 /**
  * Internal dependencies
  */
-import { createStatusAction } from './utils';
+import { createStatusAction } from '../../utils/actions';
+import { TAXONOMY_ENTITY } from '../../constants';
+import type { TaxonomyFormData } from '../types';
 
-const activateAction = createStatusAction( {
+const activateAction = createStatusAction< TaxonomyFormData >( {
 	id: 'activate',
 	label: __( 'Activate' ),
+	entity: TAXONOMY_ENTITY,
 	targetStatus: 'publish',
 	messages: {
 		successSingle: __( 'Taxonomy activated.' ),
diff --git a/packages/content-types/src/taxonomies/actions/deactivate.ts b/packages/content-types/src/taxonomies/actions/deactivate.ts
@@ -6,11 +6,14 @@ import { __, _n, sprintf } from '@wordpress/i18n';
 /**
  * Internal dependencies
  */
-import { createStatusAction } from './utils';
+import { createStatusAction } from '../../utils/actions';
+import { TAXONOMY_ENTITY } from '../../constants';
+import type { TaxonomyFormData } from '../types';
 
-const deactivateAction = createStatusAction( {
+const deactivateAction = createStatusAction< TaxonomyFormData >( {
 	id: 'deactivate',
 	label: __( 'Deactivate' ),
+	entity: TAXONOMY_ENTITY,
 	targetStatus: 'draft',
 	messages: {
 		successSingle: __( 'Taxonomy deactivated.' ),
diff --git a/packages/content-types/src/taxonomies/actions/delete.tsx b/packages/content-types/src/taxonomies/actions/delete.tsx
@@ -14,7 +14,8 @@ import { Stack, Text } from '@wordpress/ui';
 /**
  * Internal dependencies
  */
-import type { CoreDataError, TaxonomyFormData } from '../types';
+import type { TaxonomyFormData } from '../types';
+import type { CoreDataError } from '../../types';
 import { TAXONOMY_ENTITY } from '../../constants';
 
 function DeleteTaxonomyModal( {
diff --git a/packages/content-types/src/taxonomies/actions/duplicate.tsx b/packages/content-types/src/taxonomies/actions/duplicate.tsx
@@ -23,7 +23,8 @@ import { Stack } from '@wordpress/ui';
 import { useSlugField } from '../fields/general';
 import { pluralLabelField, singularLabelField } from '../../utils/fields';
 import { serializeForSave } from '../utils';
-import type { CoreDataError, TaxonomyFormData } from '../types';
+import type { TaxonomyFormData } from '../types';
+import type { CoreDataError } from '../../types';
 import { TAXONOMY_ENTITY } from '../../constants';
 
 const SLUG_MAX_LENGTH = 32;
diff --git a/packages/content-types/src/taxonomies/types.ts b/packages/content-types/src/taxonomies/types.ts
@@ -66,5 +66,3 @@ export interface TaxonomyFormData extends ContentType {
 		show_admin_column: boolean;
 	};
 }
-
-export type CoreDataError = { message?: string; code?: string };
diff --git a/packages/content-types/src/types.ts b/packages/content-types/src/types.ts
@@ -17,3 +17,5 @@ export interface ContentType {
 		show_in_rest: boolean;
 	};
 }
+
+export type CoreDataError = { message?: string; code?: string };
diff --git a/packages/content-types/src/utils/actions.ts b/packages/content-types/src/utils/actions.ts
@@ -8,15 +8,13 @@ import { store as noticesStore } from '@wordpress/notices';
 /**
  * Internal dependencies
  */
-import type { CoreDataError, TaxonomyFormData } from '../types';
-import { TAXONOMY_ENTITY } from '../../constants';
-
-type Status = TaxonomyFormData[ 'status' ];
+import type { ContentType, CoreDataError } from '../types';
 
 export interface StatusActionConfig {
 	id: string;
 	label: string;
-	targetStatus: Status;
+	entity: string;
+	targetStatus: ContentType[ 'status' ];
 	messages: {
 		successSingle: string;
 		successMany: ( count: number ) => string;
@@ -27,11 +25,10 @@ export interface StatusActionConfig {
 	};
 }
 
-export function createStatusAction(
+export function createStatusAction< T extends ContentType >(
 	config: StatusActionConfig
-): Action< TaxonomyFormData > {
-	const isEligible = ( item: TaxonomyFormData ) =>
-		item.status !== config.targetStatus;
+): Action< T > {
+	const isEligible = ( item: T ) => item.status !== config.targetStatus;
 	return {
 		id: config.id,
 		label: config.label,
@@ -49,7 +46,7 @@ export function createStatusAction(
 				itemsToUpdate.map( ( item ) =>
 					saveEntityRecord(
 						'postType',
-						TAXONOMY_ENTITY,
+						config.entity,
 						{ id: item.id, status: config.targetStatus },
 						{ throwOnError: true }
 					)
diff --git a/packages/content-types/src/utils/fields.tsx b/packages/content-types/src/utils/fields.tsx
@@ -139,26 +139,11 @@ export const pluralLabelField: Field< ContentType > = {
 	},
 };
 
-export const singularLabelField: Field< ContentType > = {
-	id: 'singular_name',
-	label: __( 'Singular label' ),
-	type: 'text',
-	getValue: ( { item } ) => item.config.labels.singular_name,
-	setValue: ( { item, value } ) => ( {
-		config: {
-			...item.config,
-			labels: {
-				...item.config.labels,
-				singular_name: String( value ?? '' ),
-			},
-		},
-	} ),
-	isValid: {
-		required: true,
-		maxLength: 200,
-	},
-	enableSorting: false,
-};
+export const singularLabelField = createLabelField(
+	'singular_name',
+	__( 'Singular label' ),
+	{ required: true }
+);
 
 export function createDescriptionField(
 	description: string

Original file line number	Diff line number	Diff line change
`@@ -86,5 +86,3 @@ export interface PostTypeFormData extends ContentType {`
`86`	`86`	`has_archive: boolean;`
`87`	`87`	`};`
`88`	`88`	`}`
`89`		`-`
`90`		`-export type CoreDataError = { message?: string; code?: string };`