Sync package-lock.json on latest NPM#70839
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Task
|
Size Change: -630 B (-0.03%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
sirreal
approved these changes
Jul 22, 2025
Member
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
Thank you.
On trunk, npm ci fails (lockfile out of date). On this branch it works correctly with npm 10 and 11.
I'm surprised CI does not prevent getting into this state.
Member
Author
I opened #70844 as a potential improvement here. |
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates
package-lock.jsonto commit changes caused ontrunkwhen runningnpm installwith the latest version of npm (v11.4.2 at time of writing).Split from #70799
Why?
npm installshould not cause local changespackage-lock.jsonshould be kept in sync with the result ofnpm installTesting Instructions
You can manually verify these changes are correct on trunk:
git checkout trunknpm install -g npm@latestnpm installgit diff update/sync-package-lock