Skip to content

Install latest NPM for CI static checks #70844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduth wants to merge 1 commit into from
Closed

Install latest NPM for CI static checks #70844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/static-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
check-latest: true
cache: npm

- name: Install latest npm
run: npm install -g npm@latest

- name: Npm install
# A "full" install is executed, since `npm ci` does not always exit
# with an error status code if the lock file is inaccurate. This also
Comment on lines 46 to 48
Copy link
Copy Markdown
Member

@sirreal sirreal Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can also use npm ci here now? I think that would help catch issues. I'm looking at a recent trunk (7a1f29f) with the out-of-date lock file and npm ci does seem to exit with non-0 status, $? is 1 for me with npm 11.4.2.

Expand Down
Loading